Skip to content

Commit

Permalink
AMDGPU: Remove some invalid kill flags in tests
Browse files Browse the repository at this point in the history
These killed registers need to be live out of the block but the
verifier wasn't catching it.
  • Loading branch information
arsenm committed May 3, 2022
1 parent 5dfe4b7 commit 574ca03
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions llvm/test/CodeGen/AMDGPU/optimize-compare.mir
Expand Up @@ -161,7 +161,7 @@ body: |
; GCN-NEXT: bb.1:
; GCN-NEXT: successors: %bb.2(0x40000000), %bb.1(0x40000000)
; GCN-NEXT: {{ $}}
; GCN-NEXT: S_CMP_EQ_I32 killed [[S_AND_B32_]], 1, implicit-def $scc
; GCN-NEXT: S_CMP_EQ_I32 [[S_AND_B32_]], 1, implicit-def $scc
; GCN-NEXT: S_CBRANCH_SCC0 %bb.2, implicit $scc
; GCN-NEXT: S_BRANCH %bb.1
; GCN-NEXT: {{ $}}
Expand All @@ -181,7 +181,7 @@ body: |
bb.1:
successors: %bb.2(0x40000000), %bb.1(0x40000000)
S_CMP_EQ_I32 killed %1:sreg_32, 1, implicit-def $scc
S_CMP_EQ_I32 %1:sreg_32, 1, implicit-def $scc
S_CBRANCH_SCC0 %bb.2, implicit $scc
S_BRANCH %bb.1
Expand Down Expand Up @@ -1403,7 +1403,7 @@ body: |
; GCN-NEXT: {{ $}}
; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $sgpr0
; GCN-NEXT: [[S_AND_B32_:%[0-9]+]]:sreg_32 = S_AND_B32 1, killed [[COPY]], implicit-def dead $scc
; GCN-NEXT: S_CMP_EQ_U32 killed [[S_AND_B32_]], 0, implicit-def $scc
; GCN-NEXT: S_CMP_EQ_U32 [[S_AND_B32_]], 0, implicit-def $scc
; GCN-NEXT: S_CBRANCH_SCC0 %bb.2, implicit $scc
; GCN-NEXT: S_BRANCH %bb.1
; GCN-NEXT: {{ $}}
Expand All @@ -1420,7 +1420,7 @@ body: |
%0:sreg_32 = COPY $sgpr0
%1:sreg_32 = S_AND_B32 1, killed %0, implicit-def dead $scc
S_CMP_EQ_U32 killed %1:sreg_32, 0, implicit-def $scc
S_CMP_EQ_U32 %1:sreg_32, 0, implicit-def $scc
S_CBRANCH_SCC0 %bb.2, implicit $scc
S_BRANCH %bb.1
Expand Down Expand Up @@ -2008,7 +2008,7 @@ body: |
%0:sreg_32 = COPY $sgpr0
%1:sreg_32 = S_AND_B32 2, killed %0, implicit-def dead $scc
S_CMP_EQ_U32 killed %1:sreg_32, 2, implicit-def $scc
S_CMP_EQ_U32 %1:sreg_32, 2, implicit-def $scc
S_CBRANCH_SCC0 %bb.2, implicit $scc
S_BRANCH %bb.1
Expand Down
Expand Up @@ -423,7 +423,7 @@ body: |
%2:sreg_64_xexec = V_CMP_NE_U32_e64 %1, 1, implicit $exec
bb.1:
$vcc = S_AND_B64 $exec, killed %2, implicit-def dead $scc
$vcc = S_AND_B64 $exec, %2, implicit-def dead $scc
S_CBRANCH_VCCNZ %bb.3, implicit killed $vcc
S_BRANCH %bb.2
Expand Down Expand Up @@ -475,7 +475,7 @@ body: |
%0.sub0_sub1:sgpr_128 = IMPLICIT_DEF
%1:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, 1, %0.sub0_sub1, implicit $exec
%2.sub0_sub1:sgpr_128 = V_CMP_NE_U32_e64 %1, 1, implicit $exec
$vcc = S_AND_B64 $exec, killed %2.sub0_sub1:sgpr_128, implicit-def dead $scc
$vcc = S_AND_B64 $exec, %2.sub0_sub1:sgpr_128, implicit-def dead $scc
S_CBRANCH_VCCNZ %bb.2, implicit killed $vcc
S_BRANCH %bb.1
Expand Down

0 comments on commit 574ca03

Please sign in to comment.