-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang][CodeGen] Handle template parameter objects with explicit addr…
…ess spaces (#69266) For certain cases (e.g. when their address is observable at run time) it is necessary to provide physical backing for non-type template parameter objects. Said backing comes in the form of a global variable. For certain targets (e.g. AMDGPU), which use a non-default address space for globals, this can lead to an issue when referencing said global in address space agnostic languages (such as HIP), for example when passing them to a function. This patch addresses this issue by inserting an address space cast iff there is an address space mismatch between the type of a reference expression and the address space of the backing global. A test is also added.
- Loading branch information
Showing
2 changed files
with
46 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
clang/test/CodeGenCXX/template-param-objects-address-space.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -std=c++20 %s -emit-llvm -o - | FileCheck %s | ||
|
||
struct S { char buf[32]; }; | ||
template<S s> constexpr const char *begin() { return s.buf; } | ||
template<S s> constexpr const char *end() { return s.buf + __builtin_strlen(s.buf); } | ||
template<S s> constexpr const void *retval() { return &s; } | ||
extern const void *callee(const S*); | ||
template<S s> constexpr const void* observable_addr() { return callee(&s); } | ||
|
||
// CHECK: [[HELLO:@_ZTAXtl1StlA32_cLc104ELc101ELc108ELc108ELc111ELc32ELc119ELc111ELc114ELc108ELc100EEEE]] | ||
// CHECK-SAME: = linkonce_odr addrspace(1) constant { <{ [11 x i8], [21 x i8] }> } { <{ [11 x i8], [21 x i8] }> <{ [11 x i8] c"hello world", [21 x i8] zeroinitializer }> }, comdat | ||
|
||
// CHECK: @p | ||
// CHECK-SAME: addrspace(1) global ptr addrspacecast (ptr addrspace(1) [[HELLO]] to ptr) | ||
const char *p = begin<S{"hello world"}>(); | ||
|
||
// CHECK: @q | ||
// CHECK-SAME: addrspace(1) global ptr addrspacecast (ptr addrspace(1) getelementptr (i8, ptr addrspace(1) [[HELLO]], i64 11) to ptr) | ||
const char *q = end<S{"hello world"}>(); | ||
|
||
const void *(*r)() = &retval<S{"hello world"}>; | ||
|
||
// CHECK: @s | ||
// CHECK-SAME: addrspace(1) global ptr null | ||
const void *s = observable_addr<S{"hello world"}>(); | ||
|
||
// CHECK: define linkonce_odr noundef ptr @_Z6retvalIXtl1StlA32_cLc104ELc101ELc108ELc108ELc111ELc32ELc119ELc111ELc114ELc108ELc100EEEEEPKvv() | ||
// CHECK: ret ptr addrspacecast (ptr addrspace(1) [[HELLO]] to ptr) | ||
|
||
// CHECK: define linkonce_odr noundef ptr @_Z15observable_addrIXtl1StlA32_cLc104ELc101ELc108ELc108ELc111ELc32ELc119ELc111ELc114ELc108ELc100EEEEEPKvv() | ||
// CHECK: %call = call noundef ptr @_Z6calleePK1S(ptr noundef addrspacecast (ptr addrspace(1) [[HELLO]] to ptr)) | ||
// CHECK: declare noundef ptr @_Z6calleePK1S(ptr noundef) |