Skip to content

Commit

Permalink
[CMake] Fail when Python interpreter doesn't match Python libraries v…
Browse files Browse the repository at this point in the history
…ersion

Because of how CMake finds the Python libraries and interpreter, it's
possible to end up with a discrepancy between the two. For example,
you'd end up using a Python 3 interpreter to run the test suite while
LLDB was built and linked against Python 2.

This patch adds a fatal error to CMake so we find out at configuration
time, instead of finding out at test time.

Differential revision: https://reviews.llvm.org/D64812

llvm-svn: 366243
  • Loading branch information
JDevlieghere committed Jul 16, 2019
1 parent 7eb1902 commit 5826ab6
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lldb/cmake/modules/LLDBConfig.cmake
Expand Up @@ -185,7 +185,6 @@ function(find_python_libs_windows)
endfunction(find_python_libs_windows)

if (NOT LLDB_DISABLE_PYTHON)

if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
find_python_libs_windows()

Expand All @@ -194,8 +193,12 @@ if (NOT LLDB_DISABLE_PYTHON)
add_definitions( -DLLDB_PYTHON_HOME="${LLDB_PYTHON_HOME}" )
endif()
else()
find_package(PythonInterp)
find_package(PythonLibs)
find_package(PythonInterp REQUIRED)
find_package(PythonLibs REQUIRED)
endif()

if (NOT PYTHON_VERSION_STRING VERSION_EQUAL PYTHONLIBS_VERSION_STRING)
message(FATAL_ERROR "Found incompatible Python interpreter (${PYTHON_VERSION_STRING}) and Python libraries (${PYTHONLIBS_VERSION_STRING})")
endif()

if (PYTHON_INCLUDE_DIR)
Expand Down

0 comments on commit 5826ab6

Please sign in to comment.