Skip to content

Commit

Permalink
[Transforms] Preserve metadata when converting invoke to call.
Browse files Browse the repository at this point in the history
The `changeToCall` function did not preserve the invoke's metadata.
Currently, there is probably no metadata that depends on being applied
on a CallInst or InvokeInst. Therefore we can replace the instruction's
metadata.

This fixes http://llvm.org/PR39994

Suggested-by: Moritz Kreutzer <moritz.kreutzer@siemens.com>

Differential Revision: https://reviews.llvm.org/D55666

llvm-svn: 349170
  • Loading branch information
Meinersbur committed Dec 14, 2018
1 parent 8fb9a71 commit 5948b7f
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 0 deletions.
1 change: 1 addition & 0 deletions llvm/lib/Transforms/Utils/Local.cpp
Expand Up @@ -1970,6 +1970,7 @@ static void changeToCall(InvokeInst *II, DomTreeUpdater *DTU = nullptr) {
NewCall->setCallingConv(II->getCallingConv());
NewCall->setAttributes(II->getAttributes());
NewCall->setDebugLoc(II->getDebugLoc());
NewCall->copyMetadata(*II);
II->replaceAllUsesWith(NewCall);

// Follow the call by a branch to the normal destination.
Expand Down
44 changes: 44 additions & 0 deletions llvm/test/Transforms/PruneEH/looptest.ll
@@ -0,0 +1,44 @@
; RUN: opt < %s -prune-eh -S | FileCheck %s

declare void @nounwind() nounwind

define internal void @foo() {
call void @nounwind()
ret void
}

; CHECK-LABEL: @caller
define i32 @caller(i32 %n) personality i32 (...)* @__gxx_personality_v0 {
entry:
br label %for

for:
%j = phi i32 [0, %entry], [%j.inc, %inc]
%j.cmp = icmp slt i32 %j, %n
br i1 %j.cmp, label %body, label %exit, !llvm.loop !0

body:
; CHECK: call void @foo(), !llvm.mem.parallel_loop_access !0
invoke void @foo( )
to label %Normal unwind label %Except, !llvm.mem.parallel_loop_access !0
br label %inc

inc:
%j.inc = add nuw nsw i32 %j, 1
br label %for, !llvm.loop !0

exit:
br label %Normal

Normal:
ret i32 0

Except:
landingpad { i8*, i32 }
catch i8* null
ret i32 1
}

declare i32 @__gxx_personality_v0(...)

!0 = distinct !{!0}

0 comments on commit 5948b7f

Please sign in to comment.