-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
clang/APINotes: squelch a -Wparantheses warning (NFC)
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,7 +159,7 @@ class APINotesManager { | |
ArrayRef<APINotesReader *> getCurrentModuleReaders() const { | ||
bool HasPublic = CurrentModuleReaders[ReaderKind::Public]; | ||
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private]; | ||
assert(!HasPrivate || HasPublic && "private module requires public module"); | ||
assert(!HasPrivate || (HasPublic && "private module requires public module")); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dwblaikie
Collaborator
|
||
if (!HasPrivate && !HasPublic) | ||
return {}; | ||
return ArrayRef(CurrentModuleReaders).slice(0, HasPrivate ? 2 : 1); | ||
|
While it doesn't matter in terms of the semantics of this test, I think probably the suitable parentheses would be like this:
Could you change it to that?