Skip to content

Commit

Permalink
kmp_lock.h: Fix VS2013 build after r271324
Browse files Browse the repository at this point in the history
MSVC doesn't allow std::atomic<>s in a union since they don't have trivial
copy constructor. Replacing them with e.g. std::atomic_int works, but that
breaks the GCC build on Linux, because then calls to e.g. std::atomic_load_explicit
fail, as they expect a real std::atomic<> pointer.

Fixing this with an #ifdef to unbreak the build for now.

llvm-svn: 272271
  • Loading branch information
zmodem committed Jun 9, 2016
1 parent d2454d6 commit 5b89fbc
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions openmp/runtime/src/kmp_lock.h
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,21 @@ extern void __kmp_destroy_nested_futex_lock( kmp_futex_lock_t *lck );

#ifdef __cplusplus

#ifdef _MSC_VER
// MSVC won't allow use of std::atomic<> in a union since it has non-trivial copy constructor.

struct kmp_base_ticket_lock {
// `initialized' must be the first entry in the lock data structure!
std::atomic_bool initialized;
volatile union kmp_ticket_lock *self; // points to the lock union
ident_t const * location; // Source code location of omp_init_lock().
std::atomic_uint next_ticket; // ticket number to give to next thread which acquires
std::atomic_uint now_serving; // ticket number for thread which holds the lock
std::atomic_int owner_id; // (gtid+1) of owning thread, 0 if unlocked
std::atomic_int depth_locked; // depth locked, for nested locks only
kmp_lock_flags_t flags; // lock specifics, e.g. critical section lock
};
#else
struct kmp_base_ticket_lock {
// `initialized' must be the first entry in the lock data structure!
std::atomic<bool> initialized;
Expand All @@ -248,6 +263,7 @@ struct kmp_base_ticket_lock {
std::atomic<int> depth_locked; // depth locked, for nested locks only
kmp_lock_flags_t flags; // lock specifics, e.g. critical section lock
};
#endif

#else // __cplusplus

Expand Down

0 comments on commit 5b89fbc

Please sign in to comment.