Skip to content

Commit

Permalink
[SampleFDO] Remove 'using namespace' (NFC)
Browse files Browse the repository at this point in the history
Remove 'using namespace' statement from header file to avoid propagating it to
other locations unnecessarily and avoid potential name collisions.

Reviewed By: wenlei

Differential Revision: https://reviews.llvm.org/D152727
  • Loading branch information
asif-manzoor authored and Muhammad Asif Manzoor (A) committed Jun 14, 2023
1 parent 7a50e78 commit 5bb9bf5
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions llvm/include/llvm/Support/Discriminator.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ enum FSDiscriminatorPass {
};
} // namespace sampleprof

using namespace sampleprof;

// The number of bits reserved for the base discrimininator. The base
// discriminaitor starts from bit 0.
static const unsigned BaseDiscriminatorBitWidth = 8;
Expand All @@ -82,33 +80,36 @@ static const unsigned FSDiscriminatorBitWidth = 6;
// + FSDiscriminatorBitWidth * getNumFSPasses()
// needs to fit in an unsigned int type.
static inline unsigned getNumFSPasses() {
return static_cast<unsigned>(FSDiscriminatorPass::PassLast);
return static_cast<unsigned>(sampleprof::FSDiscriminatorPass::PassLast);
}

// Return the ending bit for FSPass P.
static inline unsigned getFSPassBitEnd(FSDiscriminatorPass P) {
static inline unsigned getFSPassBitEnd(sampleprof::FSDiscriminatorPass P) {
unsigned I = static_cast<unsigned>(P);
assert(I <= getNumFSPasses() && "Invalid FS discriminator pass number.");
return BaseDiscriminatorBitWidth + I * FSDiscriminatorBitWidth - 1;
}

// Return the begining bit for FSPass P.
static inline unsigned getFSPassBitBegin(FSDiscriminatorPass P) {
if (P == FSDiscriminatorPass::Base)
static inline unsigned getFSPassBitBegin(sampleprof::FSDiscriminatorPass P) {
if (P == sampleprof::FSDiscriminatorPass::Base)
return 0;
unsigned I = static_cast<unsigned>(P);
assert(I <= getNumFSPasses() && "Invalid FS discriminator pass number.");
return getFSPassBitEnd(static_cast<FSDiscriminatorPass>(I - 1)) + 1;
return getFSPassBitEnd(static_cast<sampleprof::FSDiscriminatorPass>(I - 1)) +
1;
}

// Return the beginning bit for the last FSPass.
static inline int getLastFSPassBitBegin() {
return getFSPassBitBegin(static_cast<FSDiscriminatorPass>(getNumFSPasses()));
return getFSPassBitBegin(
static_cast<sampleprof::FSDiscriminatorPass>(getNumFSPasses()));
}

// Return the ending bit for the last FSPass.
static inline unsigned getLastFSPassBitEnd() {
return getFSPassBitEnd(static_cast<FSDiscriminatorPass>(getNumFSPasses()));
return getFSPassBitEnd(
static_cast<sampleprof::FSDiscriminatorPass>(getNumFSPasses()));
}

// Return the beginning bit for the base (first) FSPass.
Expand Down

0 comments on commit 5bb9bf5

Please sign in to comment.