Skip to content

Commit

Permalink
Enable workaround for finding functions in global namespace on linux …
Browse files Browse the repository at this point in the history
…binaries on

all hosts.

We require a workaround to be able to locate global and anonymous namespace
functions in the dwarf symbols on linux binaries. This patch enables this code
on all platforms so that we can still find these symbols when debugging from a
different host platform.

Test Plan:
The following tests begin passing when running with a mac host to linux client:
TestCallCPPFunction.py
TestCallStopAndContinue.py
TestExprs.py
TestExprsChar.py
TestNamespace.py
TestOverloadedFunctions.py
TestRvalueReferences.py
TestThreadExit.py

Differential Revision: http://reviews.llvm.org/D9754

llvm-svn: 237270
  • Loading branch information
flackr committed May 13, 2015
1 parent c74e33b commit 5cbd3bf
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Expand Up @@ -4033,8 +4033,7 @@ SymbolFileDWARF::FindFunctions (const ConstString &name,
FindFunctions (name, m_function_fullname_index, include_inlines, sc_list);

// FIXME Temporary workaround for global/anonymous namespace
// functions on FreeBSD and Linux
#if defined (__FreeBSD__) || defined (__linux__)
// functions debugging FreeBSD and Linux binaries.
// If we didn't find any functions in the global namespace try
// looking in the basename index but ignore any returned
// functions that have a namespace (ie. mangled names starting with
Expand All @@ -4061,7 +4060,6 @@ SymbolFileDWARF::FindFunctions (const ConstString &name,
}
}
}
#endif
}
DIEArray die_offsets;
DWARFCompileUnit *dwarf_cu = NULL;
Expand Down

0 comments on commit 5cbd3bf

Please sign in to comment.