Skip to content

Commit

Permalink
[opt-viewer] Listify dict_items for Py3 indexing
Browse files Browse the repository at this point in the history
Summary:
In Python 2, calling `dict.items()` returns an indexable `list`, whereas
on Python 3 it returns a set-like `dict_items` object, which cannot be
indexed. Explicitly onvert the `dict_items` object so that it can be
indexed when using Python 3.

In combination with D36622, D36623, and D36624, this change allows
`opt-viewer.py` to exit successfully when run with Python 3.4.

Test Plan:
Run `opt-viewer.py` using Python 3.4 and confirm it does not encounter a
runtime error when when indexing into `dict.items()`.

Reviewers: anemet

Reviewed By: anemet

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D36630

llvm-svn: 310810
  • Loading branch information
modocache committed Aug 14, 2017
1 parent fe6b509 commit 60a3185
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/tools/opt-viewer/optrecord.py
Expand Up @@ -146,7 +146,7 @@ def getArgString(self, mapping):
del mapping['DebugLoc']

assert(len(mapping) == 1)
(key, value) = mapping.items()[0]
(key, value) = list(mapping.items())[0]

if key == 'Caller' or key == 'Callee':
value = cgi.escape(demangle(value))
Expand Down

0 comments on commit 60a3185

Please sign in to comment.