Skip to content

Commit

Permalink
llvm-nm: print 'n' instead of '?'
Browse files Browse the repository at this point in the history
This matches gnu nm and has the advantage that there is a upper case N.

llvm-svn: 240655
  • Loading branch information
espindola committed Jun 25, 2015
1 parent 9ec96a2 commit 60c1a8c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion llvm/test/Object/X86/nm-print-size.s
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
// RUN: llvm-mc %s -o %t -filetype=obj -triple=x86_64-pc-linux
// RUN: llvm-nm --print-size %t | FileCheck %s

// CHECK: 0000000000000000 ffffffffffffffff t a
// CHECK: 0000000000000000 ffffffffffffffff n a
// CHECK: 0000000000000000 0000000000000000 N b

.section foo
a:
.size a, 0xffffffffffffffff

.global b
b:
2 changes: 1 addition & 1 deletion llvm/tools/llvm-nm/llvm-nm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ static char getSymbolNMTypeChar(ELFObjectFile<ELFT> &Obj,
.Default('?');
}

return '?';
return 'n';
}

static char getSymbolNMTypeChar(COFFObjectFile &Obj, symbol_iterator I) {
Expand Down

0 comments on commit 60c1a8c

Please sign in to comment.