Skip to content

Commit

Permalink
[llvm-readobj] - Remove excessive dynamic.test
Browse files Browse the repository at this point in the history
dynamic.test is a test that checks dumping of
dynamic tags. It uses precompiled objects as inputs
and it is completely excessive nowadays:

Now we have elf-dynamic-tags-machine-specific.test
and elf-dynamic-tags.test. 
(https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test)
(https://github.com/llvm-mirror/llvm/blob/master/test/tools/llvm-readobj/elf-dynamic-tags.test)

First is used to check target specific tags and second tests the common flags.
These tests use YAML, which is much better than using precompiled binaries.

Note that new reviews tend to update the YAML based
tests to add new tags, e.g. see D62596.

With this patch it became possible to remove
dynamic-table-so.aarch64 binary from the inputs folder.
(other binaries are still used in other tests).

Differential revision: https://reviews.llvm.org/D62728

llvm-svn: 362224
  • Loading branch information
George Rimar committed May 31, 2019
1 parent 155bd6c commit 60d88e0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 248 deletions.
Binary file not shown.
2 changes: 0 additions & 2 deletions llvm/test/tools/llvm-readobj/Inputs/dynamic-table.c
Expand Up @@ -4,8 +4,6 @@
// -o dynamic-table-so.mips
// clang -target mipsel-linux-gnu -lc dynamic-table.c \
// -o dynamic-table-exe.mips
// clang -target aarch64-linux-gnu -fPIC -shared dynamic-table.c\
// -o dynamic-table-so.aarch64
int puts(const char *);

__thread int foo;
Expand Down
246 changes: 0 additions & 246 deletions llvm/test/tools/llvm-readobj/dynamic.test

This file was deleted.

0 comments on commit 60d88e0

Please sign in to comment.