Skip to content

Commit

Permalink
[BOLT] LongJmp: Fix hot text section alignment
Browse files Browse the repository at this point in the history
The BinaryEmitter uses opts::AlignText value to align the hot text
section. Also check that the opts::AlignText is at least
equal opts::AlignFunctions for the same reason, as described in D121392.

Vladislav Khmelevsky,
Advanced Software Technology Lab, Huawei

Differential Revision: https://reviews.llvm.org/D121728
  • Loading branch information
yota9 committed Mar 16, 2022
1 parent 0389462 commit 62a289d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 4 additions & 3 deletions bolt/lib/Passes/LongJmp.cpp
Expand Up @@ -18,6 +18,7 @@ using namespace llvm;

namespace opts {
extern cl::OptionCategory BoltOptCategory;
extern llvm::cl::opt<unsigned> AlignText;
extern cl::opt<unsigned> AlignFunctions;
extern cl::opt<bool> UseOldText;
extern cl::opt<bool> HotFunctionsAtEnd;
Expand Down Expand Up @@ -342,7 +343,7 @@ uint64_t LongJmpPass::tentativeLayoutRelocMode(
tentativeLayoutRelocColdPart(BC, SortedFunctions, DotAddress);
ColdLayoutDone = true;
if (opts::HotFunctionsAtEnd)
DotAddress = alignTo(DotAddress, BC.PageAlign);
DotAddress = alignTo(DotAddress, opts::AlignText);
}

DotAddress = alignTo(DotAddress, BinaryFunction::MinAlign);
Expand Down Expand Up @@ -390,11 +391,11 @@ void LongJmpPass::tentativeLayout(
// Initial padding
if (opts::UseOldText && EstimatedTextSize <= BC.OldTextSectionSize) {
DotAddress = BC.OldTextSectionAddress;
uint64_t Pad = offsetToAlignment(DotAddress, llvm::Align(BC.PageAlign));
uint64_t Pad = offsetToAlignment(DotAddress, llvm::Align(opts::AlignText));
if (Pad + EstimatedTextSize <= BC.OldTextSectionSize)
DotAddress += Pad;
} else {
DotAddress = alignTo(BC.LayoutStartAddress, BC.PageAlign);
DotAddress = alignTo(BC.LayoutStartAddress, opts::AlignText);
}

tentativeLayoutRelocMode(BC, SortedFunctions, DotAddress);
Expand Down
3 changes: 3 additions & 0 deletions bolt/lib/Rewrite/RewriteInstance.cpp
Expand Up @@ -1743,6 +1743,9 @@ void RewriteInstance::adjustCommandLineOptions() {
if (!opts::AlignText.getNumOccurrences())
opts::AlignText = BC->PageAlign;

if (opts::AlignText < opts::AlignFunctions)
opts::AlignText = (unsigned)opts::AlignFunctions;

if (BC->isX86() && opts::Lite.getNumOccurrences() == 0 && !opts::StrictMode &&
!opts::UseOldText)
opts::Lite = true;
Expand Down

0 comments on commit 62a289d

Please sign in to comment.