Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DWARFVerifier: Check section-relative references at the end of the se…
…ction This ensures that debug_types references aren't looked for in debug_info section. Behavior is still going to be questionable in an unlinked object file - since cross-cu references could refer to symbols in another .debug_info (or, in theory, .debug_types) chunk - but if a producer only uses ref_addr to refer to things within the same .debug_info chunk in an object file (eg: whole program optimization/LTO - producing two CUs into a single .debug_info section in an object file - the ref_addrs there could be resolved relative to that .debug_info chunk, not needing to consider comdat (DWARFv5 type units or other creatures) chunks of .debug_info, etc)
- Loading branch information
Showing
6 changed files
with
243 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_ref_addr_between.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
193 changes: 193 additions & 0 deletions
193
llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_ref_multi_section.s
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,193 @@ | ||
| # RUN: llvm-mc %s -o %t.o -filetype=obj | ||
| # RUN: llvm-dwarfdump -debug-info -verify %t.o | FileCheck %s | ||
|
|
||
| # CHECK-NOT: error: | ||
|
|
||
| # Assembly generated from this source: | ||
| # struct t1 { int i; }; | ||
| # t1 v1; | ||
| # and compiled with -g -fdebug-types-section | ||
| # | ||
| # This demonstrates that llvm-dwarfdump --verify does not try to apply offsets found in the .debug_type | ||
|
|
||
| .text | ||
| .file "test.cpp" | ||
| .file 1 "/usr/local/google/home/blaikie/dev/scratch" "test.cpp" | ||
| .section .debug_types,"G",@progbits,14297044602779165170,comdat | ||
| .long .Ldebug_info_end0-.Ldebug_info_start0 # Length of Unit | ||
| .Ldebug_info_start0: | ||
| .short 4 # DWARF version number | ||
| .long .debug_abbrev # Offset Into Abbrev. Section | ||
| .byte 8 # Address Size (in bytes) | ||
| .quad -4149699470930386446 # Type Signature | ||
| .long 30 # Type DIE Offset | ||
| .byte 1 # Abbrev [1] 0x17:0x25 DW_TAG_type_unit | ||
| .short 33 # DW_AT_language | ||
| .long .Lline_table_start0 # DW_AT_stmt_list | ||
| .byte 2 # Abbrev [2] 0x1e:0x16 DW_TAG_structure_type | ||
| .byte 5 # DW_AT_calling_convention | ||
| .long .Linfo_string6 # DW_AT_name | ||
| .byte 4 # DW_AT_byte_size | ||
| .byte 1 # DW_AT_decl_file | ||
| .byte 1 # DW_AT_decl_line | ||
| .byte 3 # Abbrev [3] 0x27:0xc DW_TAG_member | ||
| .long .Linfo_string4 # DW_AT_name | ||
| .long 52 # DW_AT_type | ||
| .byte 1 # DW_AT_decl_file | ||
| .byte 1 # DW_AT_decl_line | ||
| .byte 0 # DW_AT_data_member_location | ||
| .byte 0 # End Of Children Mark | ||
| .byte 4 # Abbrev [4] 0x34:0x7 DW_TAG_base_type | ||
| .long .Linfo_string5 # DW_AT_name | ||
| .byte 5 # DW_AT_encoding | ||
| .byte 4 # DW_AT_byte_size | ||
| .byte 0 # End Of Children Mark | ||
| .Ldebug_info_end0: | ||
| .type v1,@object # @v1 | ||
| .bss | ||
| .globl v1 | ||
| .p2align 2 | ||
| v1: | ||
| .zero 4 | ||
| .size v1, 4 | ||
|
|
||
| .section .debug_abbrev,"",@progbits | ||
| .byte 1 # Abbreviation Code | ||
| .byte 65 # DW_TAG_type_unit | ||
| .byte 1 # DW_CHILDREN_yes | ||
| .byte 19 # DW_AT_language | ||
| .byte 5 # DW_FORM_data2 | ||
| .byte 16 # DW_AT_stmt_list | ||
| .byte 23 # DW_FORM_sec_offset | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 2 # Abbreviation Code | ||
| .byte 19 # DW_TAG_structure_type | ||
| .byte 1 # DW_CHILDREN_yes | ||
| .byte 54 # DW_AT_calling_convention | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 3 # DW_AT_name | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 11 # DW_AT_byte_size | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 58 # DW_AT_decl_file | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 59 # DW_AT_decl_line | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 3 # Abbreviation Code | ||
| .byte 13 # DW_TAG_member | ||
| .byte 0 # DW_CHILDREN_no | ||
| .byte 3 # DW_AT_name | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 73 # DW_AT_type | ||
| .byte 19 # DW_FORM_ref4 | ||
| .byte 58 # DW_AT_decl_file | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 59 # DW_AT_decl_line | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 56 # DW_AT_data_member_location | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 4 # Abbreviation Code | ||
| .byte 36 # DW_TAG_base_type | ||
| .byte 0 # DW_CHILDREN_no | ||
| .byte 3 # DW_AT_name | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 62 # DW_AT_encoding | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 11 # DW_AT_byte_size | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 5 # Abbreviation Code | ||
| .byte 17 # DW_TAG_compile_unit | ||
| .byte 1 # DW_CHILDREN_yes | ||
| .byte 37 # DW_AT_producer | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 19 # DW_AT_language | ||
| .byte 5 # DW_FORM_data2 | ||
| .byte 3 # DW_AT_name | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 16 # DW_AT_stmt_list | ||
| .byte 23 # DW_FORM_sec_offset | ||
| .byte 27 # DW_AT_comp_dir | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 6 # Abbreviation Code | ||
| .byte 52 # DW_TAG_variable | ||
| .byte 0 # DW_CHILDREN_no | ||
| .byte 3 # DW_AT_name | ||
| .byte 14 # DW_FORM_strp | ||
| .byte 73 # DW_AT_type | ||
| .byte 19 # DW_FORM_ref4 | ||
| .byte 63 # DW_AT_external | ||
| .byte 25 # DW_FORM_flag_present | ||
| .byte 58 # DW_AT_decl_file | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 59 # DW_AT_decl_line | ||
| .byte 11 # DW_FORM_data1 | ||
| .byte 2 # DW_AT_location | ||
| .byte 24 # DW_FORM_exprloc | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 7 # Abbreviation Code | ||
| .byte 19 # DW_TAG_structure_type | ||
| .byte 0 # DW_CHILDREN_no | ||
| .byte 60 # DW_AT_declaration | ||
| .byte 25 # DW_FORM_flag_present | ||
| .byte 105 # DW_AT_signature | ||
| .byte 32 # DW_FORM_ref_sig8 | ||
| .byte 0 # EOM(1) | ||
| .byte 0 # EOM(2) | ||
| .byte 0 # EOM(3) | ||
| .section .debug_info,"",@progbits | ||
| .Lcu_begin0: | ||
| .long .Ldebug_info_end1-.Ldebug_info_start1 # Length of Unit | ||
| .Ldebug_info_start1: | ||
| .short 4 # DWARF version number | ||
| .long .debug_abbrev # Offset Into Abbrev. Section | ||
| .byte 8 # Address Size (in bytes) | ||
| .byte 5 # Abbrev [5] 0xb:0x32 DW_TAG_compile_unit | ||
| .long .Linfo_string0 # DW_AT_producer | ||
| .short 33 # DW_AT_language | ||
| .long .Linfo_string1 # DW_AT_name | ||
| .long .Lline_table_start0 # DW_AT_stmt_list | ||
| .long .Linfo_string2 # DW_AT_comp_dir | ||
| .byte 6 # Abbrev [6] 0x1e:0x15 DW_TAG_variable | ||
| .long .Linfo_string3 # DW_AT_name | ||
| .long 51 # DW_AT_type | ||
| # DW_AT_external | ||
| .byte 1 # DW_AT_decl_file | ||
| .byte 2 # DW_AT_decl_line | ||
| .byte 9 # DW_AT_location | ||
| .byte 3 | ||
| .quad v1 | ||
| .byte 7 # Abbrev [7] 0x33:0x9 DW_TAG_structure_type | ||
| # DW_AT_declaration | ||
| .quad -4149699470930386446 # DW_AT_signature | ||
| .byte 0 # End Of Children Mark | ||
| .Ldebug_info_end1: | ||
| .section .debug_str,"MS",@progbits,1 | ||
| .Linfo_string0: | ||
| .asciz "clang version 14.0.0 (git@github.com:llvm/llvm-project.git 7f00c7ce4b186ab8ba2ae66c82efdcf908c61019)" # string offset=0 | ||
| .Linfo_string1: | ||
| .asciz "test.cpp" # string offset=101 | ||
| .Linfo_string2: | ||
| .asciz "/usr/local/google/home/blaikie/dev/scratch" # string offset=110 | ||
| .Linfo_string3: | ||
| .asciz "v1" # string offset=153 | ||
| .Linfo_string4: | ||
| .asciz "i" # string offset=156 | ||
| .Linfo_string5: | ||
| .asciz "int" # string offset=158 | ||
| .Linfo_string6: | ||
| .asciz "t1" # string offset=162 | ||
| .ident "clang version 14.0.0 (git@github.com:llvm/llvm-project.git 7f00c7ce4b186ab8ba2ae66c82efdcf908c61019)" | ||
| .section ".note.GNU-stack","",@progbits | ||
| .addrsig | ||
| .section .debug_line,"",@progbits | ||
| .Lline_table_start0: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters