Skip to content

Commit

Permalink
[gn build] Remove unhelpful default for goma_dir
Browse files Browse the repository at this point in the history
The default hasn't worked in over 9 months now.

Getting a friendly error message if this isn't set is more useful than getting
a bad default value.

Differential Revision: https://reviews.llvm.org/D115833
  • Loading branch information
nico committed Dec 15, 2021
1 parent 7ca3552 commit 6514638
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions llvm/utils/gn/build/toolchain/BUILD.gn
Expand Up @@ -3,15 +3,11 @@ import("//llvm/utils/gn/build/toolchain/compiler.gni")
declare_args() {
# If is_goma is true, the location of the goma client install.
# Set this to the output of `goma_ctl goma_dir`.
if (host_os == "win") {
goma_dir = "C:/src/goma/goma-win64"
} else {
goma_dir = getenv("HOME") + "/goma"
}
goma_dir = ""
}

assert(!use_goma || goma_dir != "",
"set goma_dir to the output of `goma_ctl goma_dir` in your args.gn")
"set `goma_dir` to the output of `goma_ctl goma_dir` in your args.gn")

template("unix_toolchain") {
toolchain(target_name) {
Expand Down

0 comments on commit 6514638

Please sign in to comment.