Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BOLT] Add support for the latest perf tool
The latest perf tool can return non-empty buffer when executing buildid-list command, even when perf.data was recorded with -B flag. Some binaries will be listed without the ID, while others may have a recorded ID. Allow invalid entires on the input, while checking the valid ones for the match. Reviewed By: Amir Differential Revision: https://reviews.llvm.org/D130223
- Loading branch information
Showing
6 changed files
with
131 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ function(add_bolt_unittest test_dirname) | |
endfunction() | ||
|
||
add_subdirectory(Core) | ||
add_subdirectory(Profile) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
add_bolt_unittest(ProfileTests | ||
DataAggregator.cpp | ||
) | ||
|
||
target_link_libraries(ProfileTests | ||
PRIVATE | ||
LLVMBOLTProfile | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
//===- bolt/unittests/Profile/DataAggregator.cpp --------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "bolt/Profile/DataAggregator.h" | ||
#include "llvm/Support/CommandLine.h" | ||
#include "gtest/gtest.h" | ||
|
||
using namespace llvm; | ||
using namespace llvm::bolt; | ||
|
||
namespace opts { | ||
extern cl::opt<bool> ReadPreAggregated; | ||
} | ||
|
||
TEST(DataAggregatorTest, buildID) { | ||
// Avoid looking for perf tool. | ||
opts::ReadPreAggregated = true; | ||
|
||
DataAggregator DA("<pseudo input>"); | ||
Optional<StringRef> FileName; | ||
|
||
DA.setParsingBuffer(""); | ||
ASSERT_FALSE(DA.hasAllBuildIDs()); | ||
FileName = DA.getFileNameForBuildID("1234"); | ||
ASSERT_FALSE(FileName); | ||
|
||
StringRef PartialValidBuildIDs = " File0\n" | ||
"1111 File1\n" | ||
" File2\n"; | ||
DA.setParsingBuffer(PartialValidBuildIDs); | ||
ASSERT_FALSE(DA.hasAllBuildIDs()); | ||
FileName = DA.getFileNameForBuildID("0000"); | ||
ASSERT_FALSE(FileName); | ||
FileName = DA.getFileNameForBuildID("1111"); | ||
ASSERT_EQ(*FileName, "File1"); | ||
|
||
StringRef AllValidBuildIDs = "0000 File0\n" | ||
"1111 File1\n" | ||
"2222 File2\n"; | ||
DA.setParsingBuffer(AllValidBuildIDs); | ||
ASSERT_TRUE(DA.hasAllBuildIDs()); | ||
FileName = DA.getFileNameForBuildID("1234"); | ||
ASSERT_FALSE(FileName); | ||
FileName = DA.getFileNameForBuildID("2222"); | ||
ASSERT_EQ(*FileName, "File2"); | ||
} |