Skip to content

Commit

Permalink
[libc++abi][NFCI] Consistently group new_handler, unexpected_handler …
Browse files Browse the repository at this point in the history
…and terminate_handler

Previously, the definitions of __cxa_terminate_handler and __cxa_unexpected_handler
(and their set_xxx_handler functions) were grouped together, but the
definition of __cxa_new_handler wasn't. This commit simply moves those
to the same file to treat all handlers consistently.
  • Loading branch information
ldionne committed Sep 30, 2021
1 parent 138dc27 commit 6714e1c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
11 changes: 10 additions & 1 deletion libcxxabi/src/cxa_default_handlers.cpp
Expand Up @@ -5,7 +5,8 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//
// This file implements the default terminate_handler and unexpected_handler.
// This file implements the default terminate_handler, unexpected_handler and
// new_handler.
//===----------------------------------------------------------------------===//

#include <exception>
Expand Down Expand Up @@ -104,6 +105,8 @@ _LIBCPP_SAFE_STATIC std::terminate_handler __cxa_terminate_handler = default_ter
_LIBCXXABI_DATA_VIS
_LIBCPP_SAFE_STATIC std::unexpected_handler __cxa_unexpected_handler = default_unexpected_handler;

std::new_handler __cxa_new_handler = 0;

namespace std
{

Expand All @@ -125,4 +128,10 @@ set_terminate(terminate_handler func) noexcept
_AO_Acq_Rel);
}

new_handler
set_new_handler(new_handler handler) noexcept
{
return __libcpp_atomic_exchange(&__cxa_new_handler, handler, _AO_Acq_Rel);
}

}
12 changes: 1 addition & 11 deletions libcxxabi/src/cxa_handlers.cpp
Expand Up @@ -6,7 +6,7 @@
//
//
// This file implements the functionality associated with the terminate_handler,
// unexpected_handler, and new_handler.
// unexpected_handler, and new_handler.
//===----------------------------------------------------------------------===//

#include <stdexcept>
Expand Down Expand Up @@ -92,16 +92,6 @@ terminate() noexcept
__terminate(get_terminate());
}

extern "C" {
new_handler __cxa_new_handler = 0;
}

new_handler
set_new_handler(new_handler handler) noexcept
{
return __libcpp_atomic_exchange(&__cxa_new_handler, handler, _AO_Acq_Rel);
}

new_handler
get_new_handler() noexcept
{
Expand Down

0 comments on commit 6714e1c

Please sign in to comment.