Skip to content

Commit

Permalink
[OpenMP][Archer][Tests] NFC: fix spurious test failure
Browse files Browse the repository at this point in the history
The test disables suppression and therefore sometimes triggers a know false
positive in the openmp runtime. The test should only verify that the env
var is handles as expected.
  • Loading branch information
jprotze committed Oct 5, 2020
1 parent e426ae2 commit 69f8740
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion openmp/tools/archer/tests/lit.cfg
Expand Up @@ -111,7 +111,7 @@ config.substitutions.append(("%clang-archer", config.test_c_compiler))
config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
config.substitutions.append(("%archer_flags", config.archer_flags))
config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append(("%nosuppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0'"))
config.substitutions.append(("%nosuppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0:exitcode=0'"))
config.substitutions.append(("%suppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1'"))
config.substitutions.append(("%deflake", os.path.join(os.path.dirname(__file__), "deflake.bash")))

Expand Down
2 changes: 0 additions & 2 deletions openmp/tools/archer/tests/parallel/parallel-nosuppression.c
Expand Up @@ -34,7 +34,5 @@ int main(int argc, char *argv[]) {
return error;
}

// CHECK-NOT: ThreadSanitizer: data race
// CHECK-NOT: ThreadSanitizer: reported
// CHECK: Warning: please export TSAN_OPTIONS
// CHECK: DONE

0 comments on commit 69f8740

Please sign in to comment.