Skip to content

Commit

Permalink
[SelectionDAG] Verify SPLAT_VECTOR nodes when they are created. (#88305)
Browse files Browse the repository at this point in the history
This applies the same rules we have for the scalar operands of a
BUILD_VECTOR where the scalar type must match the element type or for
integer vectors we allow the scalar type to be larger than the element
type. Hexagon uses i32 for an FP zero vector so we allow that as an
exception.
  • Loading branch information
topperc committed Apr 12, 2024
1 parent dcd097c commit 6a85cf8
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6032,6 +6032,17 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
if (N1.getValueType().getScalarType() == MVT::i1)
return getNode(ISD::VECREDUCE_AND, DL, VT, N1);
break;
case ISD::SPLAT_VECTOR:
assert(VT.isVector() && "Wrong return type!");
// FIXME: Hexagon uses i32 scalar for a floating point zero vector so allow
// that for now.
assert((VT.getVectorElementType() == N1.getValueType() ||
(VT.isFloatingPoint() && N1.getValueType() == MVT::i32) ||
(VT.getVectorElementType().isInteger() &&
N1.getValueType().isInteger() &&
VT.getVectorElementType().bitsLE(N1.getValueType()))) &&
"Wrong operand type!");
break;
}

SDNode *N;
Expand Down

0 comments on commit 6a85cf8

Please sign in to comment.