[clang][dataflow] Use existing accessors to check for copy and move a…

…ssignment ops. Reviewed By: gribozavr2 Differential Revision: https://reviews.llvm.org/D148612
llvm · Apr 24, 2023 · 6b85cc1 · 6b85cc1
1 parent 0b7f53e
commit 6b85cc1
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/clang/lib/Analysis/FlowSensitive/Transfer.cpp b/clang/lib/Analysis/FlowSensitive/Transfer.cpp
@@ -646,9 +646,12 @@ class TransferVisitor : public ConstStmtVisitor<TransferVisitor> {
       assert(Arg1 != nullptr);
 
       // Evaluate only copy and move assignment operators.
-      auto *Arg0Type = Arg0->getType()->getUnqualifiedDesugaredType();
-      auto *Arg1Type = Arg1->getType()->getUnqualifiedDesugaredType();
-      if (Arg0Type != Arg1Type)
+      const auto *Method =
+          dyn_cast_or_null<CXXMethodDecl>(S->getDirectCallee());
+      if (!Method)
+        return;
+      if (!Method->isCopyAssignmentOperator() &&
+          !Method->isMoveAssignmentOperator())
         return;
 
       auto *ObjectLoc = Env.getStorageLocation(*Arg0, SkipPast::Reference);