Skip to content

Commit

Permalink
[mlir] cleanup transform payload setting
Browse files Browse the repository at this point in the history
Before the multi-handle relaxation, the transform interpreter did not
actually set payload for a handle that had no further uses as a hacky
mechanism to work around the multi-handle problem. This is no longer
necessary and can be removed to avoid debugging surprises when a handle
has no payload even when its producing op assigned it.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D135585
  • Loading branch information
ftynse committed Oct 11, 2022
1 parent 6fe0309 commit 6bb997c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ transform::TransformState::setPayloadOps(Value value,
assert(value != kTopLevelValue &&
"attempting to reset the transformation root");

// TODO: this may go now
if (value.use_empty())
return success();

auto iface = value.getType().cast<TransformTypeInterface>();
DiagnosedSilenceableFailure result =
iface.checkPayload(value.getLoc(), targets);
Expand Down

0 comments on commit 6bb997c

Please sign in to comment.