Skip to content

Commit

Permalink
Rename Mangled::GetLanguage to Mangled::GuessLanguage
Browse files Browse the repository at this point in the history
The language can not be definitively determined from the mangling, so
this new name helps clarify that fact.  This addresses the concerns raised
in http://reviews.llvm.org/rL226962.
Reviewed by: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D10723

llvm-svn: 240662
  • Loading branch information
Dawn Perchik committed Jun 25, 2015
1 parent 02c3027 commit 6c506bd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions lldb/include/lldb/Core/Mangled.h
Expand Up @@ -298,12 +298,12 @@ class Mangled
SetValue (const ConstString &name);

//----------------------------------------------------------------------
/// Get the language only if it is definitive what the language is from
/// the mangling.
/// Try to guess the language from the mangling.
///
/// For a mangled name to have a language it must have both a mangled
/// and a demangled name and it must be definitive from the mangling
/// what the language is.
/// and a demangled name and it can be guessed from the mangling what
/// the language is. Note: this will return C++ for any language that
/// uses Itanium ABI mangling.
///
/// Standard C function names will return eLanguageTypeUnknown because
/// they aren't mangled and it isn't clear what language the name
Expand All @@ -314,7 +314,7 @@ class Mangled
/// if there is no mangled or demangled counterpart.
//----------------------------------------------------------------------
lldb::LanguageType
GetLanguage ();
GuessLanguage ();

private:
//----------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Core/Mangled.cpp
Expand Up @@ -423,7 +423,7 @@ Mangled::MemorySize () const
}

lldb::LanguageType
Mangled::GetLanguage ()
Mangled::GuessLanguage ()
{
ConstString mangled = GetMangledName();
if (mangled)
Expand Down

0 comments on commit 6c506bd

Please sign in to comment.