Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SanitizerBinaryMetadata] Make module_[cd]tor external
If a COMDAT key has a local linkage, it behaves as `comdat nodeduplicate` and llvm/lib/Linker/LinkModules.cpp does not deduplicate its members. This is not intended. Switch to an external linkage to allow deduplication. See also https://maskray.me/blog/2021-07-25-comdat-and-section-group#grp_comdat Reviewed By: melver Differential Revision: https://reviews.llvm.org/D143530
- Loading branch information
Showing
2 changed files
with
26 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
; RUN: opt < %s -passes='module(sanmd-module)' -sanitizer-metadata-atomics -S | FileCheck %s | ||
|
||
; CHECK: $__sanitizer_metadata_atomics.module_ctor = comdat any | ||
; CHECK: $__sanitizer_metadata_atomics.module_dtor = comdat any | ||
; CHECK: $__sanitizer_metadata_covered.module_ctor = comdat any | ||
; CHECK: $__sanitizer_metadata_covered.module_dtor = comdat any | ||
|
||
; CHECK: @llvm.used = appending global [4 x ptr] [ptr @__sanitizer_metadata_atomics.module_ctor, ptr @__sanitizer_metadata_atomics.module_dtor, ptr @__sanitizer_metadata_covered.module_ctor, ptr @__sanitizer_metadata_covered.module_dtor], section "llvm.metadata" | ||
; CHECK: @llvm.global_ctors = appending global [2 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 2, ptr @__sanitizer_metadata_atomics.module_ctor, ptr @__sanitizer_metadata_atomics.module_ctor }, { i32, ptr, ptr } { i32 2, ptr @__sanitizer_metadata_covered.module_ctor, ptr @__sanitizer_metadata_covered.module_ctor }] | ||
; CHECK: @llvm.global_dtors = appending global [2 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 2, ptr @__sanitizer_metadata_atomics.module_dtor, ptr @__sanitizer_metadata_atomics.module_dtor }, { i32, ptr, ptr } { i32 2, ptr @__sanitizer_metadata_covered.module_dtor, ptr @__sanitizer_metadata_covered.module_dtor }] | ||
|
||
; CHECK: define dso_local void @__sanitizer_metadata_covered.module_ctor() #1 comdat { | ||
; CHECK: define dso_local void @__sanitizer_metadata_covered.module_dtor() #1 comdat { | ||
|
||
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" | ||
target triple = "x86_64-unknown-linux-gnu" | ||
|
||
define i8 @foo(ptr %a) nounwind uwtable { | ||
entry: | ||
%0 = load atomic i8, ptr %a unordered, align 1 | ||
ret i8 %0 | ||
} |