Skip to content

Commit

Permalink
Fix buildbots errors after comitting D78782.
Browse files Browse the repository at this point in the history
Rename "Ranges" variables to "DebugRanges" to avoid warnings/errors on machines that have extra settings enabled.

https://reviews.llvm.org/D78782
  • Loading branch information
clayborg committed May 14, 2020
1 parent 50a81ea commit 6e73f12
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion llvm/include/llvm/ObjectYAML/DWARFYAML.h
Expand Up @@ -159,7 +159,7 @@ struct Data {
std::vector<Abbrev> AbbrevDecls;
std::vector<StringRef> DebugStrings;
std::vector<ARange> ARanges;
std::vector<Ranges> Ranges;
std::vector<Ranges> DebugRanges;
PubSection PubNames;
PubSection PubTypes;

Expand Down
16 changes: 8 additions & 8 deletions llvm/lib/ObjectYAML/DWARFEmitter.cpp
Expand Up @@ -116,18 +116,18 @@ void DWARFYAML::EmitDebugAranges(raw_ostream &OS, const DWARFYAML::Data &DI) {

void DWARFYAML::EmitDebugRanges(raw_ostream &OS, const DWARFYAML::Data &DI) {
const size_t RangesOffset = OS.tell();
for (auto Ranges : DI.Ranges) {
for (auto DebugRanges : DI.DebugRanges) {
const size_t CurrOffset = OS.tell() - RangesOffset;
assert(Ranges.Offset <= CurrOffset);
if (Ranges.Offset > CurrOffset)
ZeroFillBytes(OS, Ranges.Offset - CurrOffset);
for (auto Entry : Ranges.Entries) {
writeVariableSizedInteger(Entry.LowOffset, Ranges.AddrSize, OS,
assert(DebugRanges.Offset <= CurrOffset);
if (DebugRanges.Offset > CurrOffset)
ZeroFillBytes(OS, DebugRanges.Offset - CurrOffset);
for (auto Entry : DebugRanges.Entries) {
writeVariableSizedInteger(Entry.LowOffset, DebugRanges.AddrSize, OS,
DI.IsLittleEndian);
writeVariableSizedInteger(Entry.HighOffset, Ranges.AddrSize, OS,
writeVariableSizedInteger(Entry.HighOffset, DebugRanges.AddrSize, OS,
DI.IsLittleEndian);
}
ZeroFillBytes(OS, Ranges.AddrSize * 2);
ZeroFillBytes(OS, DebugRanges.AddrSize * 2);
}
}

Expand Down
12 changes: 6 additions & 6 deletions llvm/lib/ObjectYAML/DWARFYAML.cpp
Expand Up @@ -28,8 +28,8 @@ void MappingTraits<DWARFYAML::Data>::mapping(IO &IO, DWARFYAML::Data &DWARF) {
IO.mapOptional("debug_abbrev", DWARF.AbbrevDecls);
if (!DWARF.ARanges.empty() || !IO.outputting())
IO.mapOptional("debug_aranges", DWARF.ARanges);
if (!DWARF.Ranges.empty() || !IO.outputting())
IO.mapOptional("debug_ranges", DWARF.Ranges);
if (!DWARF.DebugRanges.empty() || !IO.outputting())
IO.mapOptional("debug_ranges", DWARF.DebugRanges);
if (!DWARF.PubNames.Entries.empty() || !IO.outputting())
IO.mapOptional("debug_pubnames", DWARF.PubNames);
if (!DWARF.PubTypes.Entries.empty() || !IO.outputting())
Expand Down Expand Up @@ -82,10 +82,10 @@ void MappingTraits<DWARFYAML::RangeEntry>::mapping(
}

void MappingTraits<DWARFYAML::Ranges>::mapping(IO &IO,
DWARFYAML::Ranges &Ranges) {
IO.mapRequired("Offset", Ranges.Offset);
IO.mapRequired("AddrSize", Ranges.AddrSize);
IO.mapRequired("Entries", Ranges.Entries);
DWARFYAML::Ranges &DebugRanges) {
IO.mapRequired("Offset", DebugRanges.Offset);
IO.mapRequired("AddrSize", DebugRanges.AddrSize);
IO.mapRequired("Entries", DebugRanges.Entries);
}

void MappingTraits<DWARFYAML::PubEntry>::mapping(IO &IO,
Expand Down
2 changes: 1 addition & 1 deletion llvm/tools/obj2yaml/dwarf2yaml.cpp
Expand Up @@ -109,7 +109,7 @@ Error dumpDebugRanges(DWARFContext &DCtx, DWARFYAML::Data &Y) {
return E;
for (const auto &RLE : DwarfRanges.getEntries())
YamlRanges.Entries.push_back({RLE.StartAddress, RLE.EndAddress});
Y.Ranges.push_back(std::move(YamlRanges));
Y.DebugRanges.push_back(std::move(YamlRanges));
}
return ErrorSuccess();
}
Expand Down

0 comments on commit 6e73f12

Please sign in to comment.