AMDGPU: Diagnose which LDS global failed to lower

Also lowercase the message to start since that seems to be the prevailing convention for error messages.
llvm · Jan 3, 2023 · 6fed2c9 · 6fed2c9
1 parent f3a113f
commit 6fed2c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp b/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
@@ -721,8 +721,9 @@ class AMDGPULowerModuleLDS : public ModulePass {
           if (K.second.size() == 1) {
             KernelAccessVariables.insert(GV);
           } else {
-            report_fatal_error("Cannot lower LDS to kernel access as it is "
-                               "reachable from multiple kernels");
+            report_fatal_error(
+                "cannot lower LDS '" + GV->getName() +
+                "' to kernel access as it is reachable from multiple kernels");
           }
           break;
 

diff --git a/llvm/test/CodeGen/AMDGPU/lower-module-lds-single-var-ambiguous.ll b/llvm/test/CodeGen/AMDGPU/lower-module-lds-single-var-ambiguous.ll
@@ -36,7 +36,7 @@ define amdgpu_kernel void @k1() {
 ;; Function accesses variable, reachable from two kernels, can't use kernel lowering for either
 ;; Hybrid can put it in module lds without cost as the first variable is free
 
-; KERNEL: LLVM ERROR: Cannot lower LDS to kernel access as it is reachable from multiple kernels
+; KERNEL: LLVM ERROR: cannot lower LDS 'function.lds' to kernel access as it is reachable from multiple kernels
 
 @function.lds = addrspace(3) global i16 undef
 define void @f0() {