Skip to content

Commit

Permalink
[tsan] Disable Trace.MemoryAccessSize on Mac
Browse files Browse the repository at this point in the history
According to comments at https://reviews.llvm.org/D107911,
Trace.MemoryAccessSize fails on Mac buildbots.
Because this test is newly introduced, and is the only user of the code
added in that patch, disable the test on Mac till the problem is
resolved.

Differential Revision: https://reviews.llvm.org/D108294
  • Loading branch information
ramosian-glider committed Aug 18, 2021
1 parent 0166690 commit 7338be0
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
Expand Up @@ -76,7 +76,14 @@ TEST(Trace, RestoreAccess) {
run_in_thread(Thread::Func);
}

TEST(Trace, MemoryAccessSize) {
#if SANITIZER_MAC
// Trace.MemoryAccessSize is currently failing on Mac.
// See https://reviews.llvm.org/D107911 for more details.
# define MAYBE_MemoryAccessSize DISABLED_MemoryAccessSize
#else
# define MAYBE_MemoryAccessSize MemoryAccessSize
#endif
TEST(Trace, MAYBE_MemoryAccessSize) {
struct Thread {
struct Params {
uptr access_size, offset, size;
Expand Down

0 comments on commit 7338be0

Please sign in to comment.