Skip to content

Commit

Permalink
[clang] Remove #undef alloca workaround (#81534)
Browse files Browse the repository at this point in the history
Added in 26670dc to workaround #4885.

Windows CI and a local Windows build are happy with this change, so it
seems like this has been properly fixed at some point. If this does
break somebody, this can be easily reverted. (Also, Linux does the same
`#define alloca` in system headers, so I'm not sure why it'd be
different on Windows)

This is tech debt that caused breakages, see comments on #71709.
  • Loading branch information
aeubanks committed Feb 13, 2024
1 parent 9be7b0a commit 742a06f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions clang/include/clang/Basic/Builtins.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
#include "llvm/ADT/StringRef.h"
#include <cstring>

// VC++ defines 'alloca' as an object-like macro, which interferes with our
// builtins.
#undef alloca

namespace clang {
class TargetInfo;
class IdentifierTable;
Expand Down

0 comments on commit 742a06f

Please sign in to comment.