Skip to content

Commit

Permalink
[compiler-rt] Don't include libc++ headers from the source tree in MSAN
Browse files Browse the repository at this point in the history
We shouldn't be including the libc++ headers from the source tree directly, since those headers are not configured (i.e. they don't use the __config_site) header like they should, which could mean up to ABI differences

Reviewed By: vitalybuka, phosek, ldionne

Differential Revision: https://reviews.llvm.org/D89915
  • Loading branch information
ldionne authored and vitalybuka committed Oct 30, 2020
1 parent d2abbc1 commit 75a1f52
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions compiler-rt/lib/msan/tests/CMakeLists.txt
Expand Up @@ -26,7 +26,6 @@ set(MSAN_UNITTEST_HEADERS
)
set(MSAN_UNITTEST_COMMON_CFLAGS
-nostdinc++
-isystem ${COMPILER_RT_LIBCXX_PATH}/include
${COMPILER_RT_UNITTEST_CFLAGS}
${COMPILER_RT_GTEST_CFLAGS}
-I${COMPILER_RT_SOURCE_DIR}/include
Expand Down Expand Up @@ -67,7 +66,8 @@ macro(msan_compile obj_list source arch kind cflags)
KIND ${kind}
COMPILE_DEPS ${MSAN_UNITTEST_HEADERS}
DEPS gtest msan
CFLAGS ${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags}
CFLAGS -isystem ${CMAKE_CURRENT_BINARY_DIR}/../libcxx_msan_${arch}/include/c++/v1
${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags}
)
endmacro()

Expand Down

0 comments on commit 75a1f52

Please sign in to comment.