Skip to content

Commit

Permalink
Fix per-processor model scheduler definition completeness check
Browse files Browse the repository at this point in the history
The CodeGenSchedModels::checkCompleteness routine in TableGen/
CodeGenSchedule.cpp is supposed to verify for each processor
model that is marked as "complete" that it actually defines a
scheduling class for each instruction.

However, this did not work correctly due to an incorrect
check whether a scheduling class has an itinerary.

Reviewer: atrick
Differential revision: https://reviews.llvm.org/D26156

llvm-svn: 285622
  • Loading branch information
uweigand committed Oct 31, 2016
1 parent 63b4a37 commit 75cda2f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion llvm/utils/TableGen/CodeGenSchedule.cpp
Expand Up @@ -1567,7 +1567,8 @@ void CodeGenSchedModels::checkCompleteness() {
const CodeGenSchedClass &SC = getSchedClass(SCIdx);
if (!SC.Writes.empty())
continue;
if (SC.ItinClassDef != nullptr)
if (SC.ItinClassDef != nullptr &&
SC.ItinClassDef->getName() != "NoItinerary")
continue;

const RecVec &InstRWs = SC.InstRWs;
Expand Down

0 comments on commit 75cda2f

Please sign in to comment.