Skip to content

Commit

Permalink
[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343…
Browse files Browse the repository at this point in the history
…095) on Windows.

Summary:
-lm is needed for these tests on Linux, but the lit config for this package automatically adds it for Linux and excludes it for Windows. So we should be able to get these tests running again by just dropping -lm and let the lit config add it when possible.

I was under the impression that -lm worked across platforms because it exists in other tests without and 'UNSUPPORTED: windows' commands (e.g. divsc3_test.c), but those are actually excluded because they 'REQUIRES: c99-complex' which is excluded from windows platforms (also by the local lit config).

I don't have easy access to a windows machine to verify this patch, but I can trigger a build bot run on clang-x64-ninja-win7 shortly after submitting.

Reviewers: hans

Subscribers: dberris, delcypher, llvm-commits, #sanitizers

Differential Revision: https://reviews.llvm.org/D52563

llvm-svn: 343245
  • Loading branch information
rupprecht committed Sep 27, 2018
1 parent 0423681 commit 777bc9f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions compiler-rt/test/builtins/Unit/compiler_rt_logb_test.c
@@ -1,6 +1,4 @@
// Linking with -lm won't work on Windows.
// UNSUPPORTED: windows
// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
// RUN: %clang_builtins %s %librt -o %t && %run %t
//===-- compiler_rt_logb_test.c - Test __compiler_rt_logb -----------------===//
//
// The LLVM Compiler Infrastructure
Expand Down
4 changes: 1 addition & 3 deletions compiler-rt/test/builtins/Unit/compiler_rt_logbf_test.c
@@ -1,6 +1,4 @@
// Linking with -lm won't work on Windows.
// UNSUPPORTED: windows
// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
// RUN: %clang_builtins %s %librt -o %t && %run %t
//===-- compiler_rt_logbf_test.c - Test __compiler_rt_logbf ---------------===//
//
// The LLVM Compiler Infrastructure
Expand Down
4 changes: 1 addition & 3 deletions compiler-rt/test/builtins/Unit/compiler_rt_logbl_test.c
@@ -1,6 +1,4 @@
// Linking with -lm won't work on Windows.
// UNSUPPORTED: windows
// RUN: %clang_builtins %s %librt -lm -o %t && %run %t
// RUN: %clang_builtins %s %librt -o %t && %run %t
//===-- compiler_rt_logbl_test.c - Test __compiler_rt_logbl ---------------===//
//
// The LLVM Compiler Infrastructure
Expand Down

0 comments on commit 777bc9f

Please sign in to comment.