Fix windows bot breakages due to D143110

llvm · Feb 2, 2023 · 795910c · 795910c · llvm-beanz · Feb 2, 2023
1 parent 4461ffd
commit 795910c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/llvm/include/llvm/Analysis/InteractiveModelRunner.h b/llvm/include/llvm/Analysis/InteractiveModelRunner.h
@@ -61,7 +61,7 @@ class InteractiveModelRunner : public MLModelRunner {
   const TensorSpec OutputSpec;
   std::error_code OutEC;
   std::error_code InEC;
-  sys::fs::file_t Inbound;
+  int Inbound = 0;
   std::vector<char> OutputBuffer;
   std::unique_ptr<Logger> Log;
 };

diff --git a/llvm/lib/Analysis/InteractiveModelRunner.cpp b/llvm/lib/Analysis/InteractiveModelRunner.cpp
@@ -59,7 +59,8 @@ InteractiveModelRunner::InteractiveModelRunner(
 }
 
 InteractiveModelRunner::~InteractiveModelRunner() {
-  sys::fs::closeFile(Inbound);
+  sys::fs::file_t FDAsOSHandle = sys::fs::convertFDToNativeFile(Inbound);
+  sys::fs::closeFile(FDAsOSHandle);
 }
 
 void *InteractiveModelRunner::evaluateUntyped() {
@@ -74,7 +75,8 @@ void *InteractiveModelRunner::evaluateUntyped() {
   const size_t Limit = OutputBuffer.size();
   while (InsPoint < Limit) {
     auto ReadOrErr = ::sys::fs::readNativeFile(
-        Inbound, {Buff + InsPoint, OutputBuffer.size() - InsPoint});
+        sys::fs::convertFDToNativeFile(Inbound),
+        {Buff + InsPoint, OutputBuffer.size() - InsPoint});
     if (ReadOrErr.takeError()) {
       Ctx.emitError("Failed reading from inbound file");
       break;

diff --git a/llvm/unittests/Analysis/MLModelRunnerTest.cpp b/llvm/unittests/Analysis/MLModelRunnerTest.cpp
@@ -167,8 +167,11 @@ TEST(InteractiveModelRunner, Evaluation) {
     // host to open the pipes RW.
     raw_fd_ostream ToCompiler(ToCompilerName, EC);
     EXPECT_FALSE(EC);
-    sys::fs::file_t FromCompiler = {};
-    EXPECT_FALSE(sys::fs::openFileForRead(FromCompilerName, FromCompiler));
+    int FromCompilerHandle = 0;
+    EXPECT_FALSE(
+        sys::fs::openFileForRead(FromCompilerName, FromCompilerHandle));
+    sys::fs::file_t FromCompiler =
+        sys::fs::convertFDToNativeFile(FromCompilerHandle);
     EXPECT_EQ(SeenObservations, 0);
     // Helper to read headers and other json lines.
     SmallVector<char, 1024> Buffer;