Skip to content

Commit

Permalink
[bolt] Fix a test affected by D131589.
Browse files Browse the repository at this point in the history
This test contained some data tables that llvm-objdump was
disassembling as code, so the test was recovering the 32-bit values in
the table from the instruction encoding column of the disassembly.

D131589 changed how llvm-objdump decides what to disassemble as code
or as data. As a result, these data tables are now being disassembled
as data, which I think is actually more sensible -- but the test
wasn't expecting it, and got confused.
  • Loading branch information
statham-arm committed Aug 24, 2022
1 parent 59cf9dd commit 79f99bf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bolt/test/AArch64/r_aarch64_prelxx.s
Expand Up @@ -17,7 +17,7 @@

// CHECKPREL32: [[#%x,DATATABLEADDR:]] <datatable>:
// CHECKPREL32-NEXT: 00:
// CHECKPREL32-NEXT: 04: [[#%x,VALUE:]]
// CHECKPREL32-NEXT: 04: {{.*}} .word 0x[[#%x,VALUE:]]

// 4 is offset in datatable
// 8 is addend
Expand All @@ -27,8 +27,8 @@
// CHECKPREL64: [[#%x,DATATABLEADDR:]] <datatable>:
// CHECKPREL64-NEXT: 00:
// CHECKPREL64-NEXT: 04:
// CHECKPREL64-NEXT: 08: [[#%x,VALUE:]]
// CHECKPREL64-NEXT: 0c: 00000000
// CHECKPREL64-NEXT: 08: {{.*}} .word 0x[[#%x,VALUE:]]
// CHECKPREL64-NEXT: 0c: {{.*}} .word 0x00000000

// 8 is offset in datatable
// 12 is addend
Expand Down

0 comments on commit 79f99bf

Please sign in to comment.