Skip to content

Commit

Permalink
[SimplifyCFG] Check if the return instruction causes undefined behavior
Browse files Browse the repository at this point in the history
This should fix rust-lang/rust#107681.

Return undefined to a noundef return value is undefined.

Example:

```
define noundef i32 @test_ret_noundef(i1 %cond) {
entry:
  br i1 %cond, label %bb1, label %bb2
bb1:
  br label %bb2
bb2:
  %r = phi i32 [ undef, %entry ], [ 1, %bb1 ]
  ret i32 %r
}
```

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D144319
  • Loading branch information
DianQK committed Feb 18, 2023
1 parent 4d5fd9b commit 7be55b0
Show file tree
Hide file tree
Showing 2 changed files with 100 additions and 0 deletions.
14 changes: 14 additions & 0 deletions llvm/lib/Transforms/Utils/SimplifyCFG.cpp
Expand Up @@ -7126,6 +7126,20 @@ static bool passingValueIsAlwaysUndefined(Value *V, Instruction *I, bool PtrValu
return passingValueIsAlwaysUndefined(V, GEP, PtrValueMayBeModified);
}

// Look through return.
if (ReturnInst *Ret = dyn_cast<ReturnInst>(Use)) {
bool HasNoUndefAttr =
Ret->getFunction()->hasRetAttribute(Attribute::NoUndef);
// Return undefined to a noundef return value is undefined.
if (isa<UndefValue>(C) && HasNoUndefAttr)
return true;
// Return null to a nonnull+noundef return value is undefined.
if (C->isNullValue() && HasNoUndefAttr &&
Ret->getFunction()->hasRetAttribute(Attribute::NonNull)) {
return true;
}
}

// Look through bitcasts.
if (BitCastInst *BC = dyn_cast<BitCastInst>(Use))
return passingValueIsAlwaysUndefined(V, BC, PtrValueMayBeModified);
Expand Down
86 changes: 86 additions & 0 deletions llvm/test/Transforms/SimplifyCFG/unreachable-eliminate-on-ret.ll
@@ -0,0 +1,86 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -passes=simplifycfg -simplifycfg-require-and-preserve-domtree=1 -S < %s | FileCheck %s

define noundef i32 @test_ret_noundef(i1 %cond) {
; CHECK-LABEL: @test_ret_noundef(
; CHECK-NEXT: entry:
; CHECK-NEXT: ret i32 1
;
entry:
br i1 %cond, label %bb1, label %bb2

bb1:
br label %bb2

bb2:
%r = phi i32 [ undef, %entry ], [ 1, %bb1 ]
ret i32 %r
}

define i32 @test_ret(i1 %cond) {
; CHECK-LABEL: @test_ret(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SPEC_SELECT:%.*]] = select i1 [[COND:%.*]], i32 1, i32 undef
; CHECK-NEXT: ret i32 [[SPEC_SELECT]]
;
entry:
br i1 %cond, label %bb1, label %bb2

bb1:
br label %bb2

bb2:
%r = phi i32 [ undef, %entry ], [ 1, %bb1 ]
ret i32 %r
}

define nonnull noundef ptr @test_ret_nonnull_noundef(i1 %cond, ptr %x) {
; CHECK-LABEL: @test_ret_nonnull_noundef(
; CHECK-NEXT: entry:
; CHECK-NEXT: call void @llvm.assume(i1 [[COND:%.*]])
; CHECK-NEXT: ret ptr [[X:%.*]]
;
entry:
br i1 %cond, label %bb1, label %bb2

bb1:
br label %bb2

bb2:
%r = phi ptr [ null, %entry ], [ %x, %bb1 ]
ret ptr %r
}

define nonnull ptr @test_ret_nonnull(i1 %cond, ptr %x) {
; CHECK-LABEL: @test_ret_nonnull(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SPEC_SELECT:%.*]] = select i1 [[COND:%.*]], ptr [[X:%.*]], ptr null
; CHECK-NEXT: ret ptr [[SPEC_SELECT]]
;
entry:
br i1 %cond, label %bb1, label %bb2

bb1:
br label %bb2

bb2:
%r = phi ptr [ null, %entry ], [ %x, %bb1 ]
ret ptr %r
}

define ptr @test_ret_ptr(i1 %cond, ptr %x) {
; CHECK-LABEL: @test_ret_ptr(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[SPEC_SELECT:%.*]] = select i1 [[COND:%.*]], ptr [[X:%.*]], ptr null
; CHECK-NEXT: ret ptr [[SPEC_SELECT]]
;
entry:
br i1 %cond, label %bb1, label %bb2

bb1:
br label %bb2

bb2:
%r = phi ptr [ null, %entry ], [ %x, %bb1 ]
ret ptr %r
}

0 comments on commit 7be55b0

Please sign in to comment.