Skip to content

Commit

Permalink
[llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of…
Browse files Browse the repository at this point in the history
… disassembled object

Summary:
This fixes the bugzilla id,41862 to support dealing with checking
stop address against start address to support this not being a
proper object to check the disasembly against like gnu objdump
currently does.

Reviewers: jakehehrlich, rupprecht, echristo, jhenderson, grimar

Reviewed By: jhenderson

Subscribers: MaskRay, smeenai, rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D61969

Patch by Nicholas Krause!

llvm-svn: 362847
  • Loading branch information
rupprecht committed Jun 7, 2019
1 parent 4ca8435 commit 7dd813f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion llvm/test/tools/llvm-objdump/X86/start-stop-address.test
Expand Up @@ -68,4 +68,5 @@
// OUT-OF-RANGE-NOT: Disassembly

// RUN: not llvm-objdump -d %t.out --start-address=0x40 --stop-address=0x3f 2>&1 | FileCheck %s --check-prefix ERRMSG
// ERRMSG: error: Start address should be less than stop address.
// RUN: not llvm-objdump -d %t.out --start-address=0x40 --stop-address=0x40 2>&1 | FileCheck %s --check-prefix ERRMSG
// ERRMSG: start address should be less than stop address.
4 changes: 2 additions & 2 deletions llvm/tools/llvm-objdump/llvm-objdump.cpp
Expand Up @@ -1417,8 +1417,8 @@ static void disassembleObject(const Target *TheTarget, const ObjectFile *Obj,
}

static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
if (StartAddress > StopAddress)
error("Start address should be less than stop address");
if (StartAddress >= StopAddress)
error("start address should be less than stop address");

const Target *TheTarget = getTarget(Obj);

Expand Down

0 comments on commit 7dd813f

Please sign in to comment.