Skip to content

Commit

Permalink
DebugInfo: Add a FIXME/suggestion about using sibling/parent index to…
Browse files Browse the repository at this point in the history
… DWARFDebugInfoEntry

As a reminder if someone comes looking to improve iteration or parent
navigation performance of DWARFDebugInfoEntry.
  • Loading branch information
dwblaikie committed Sep 6, 2021
1 parent 25fbbc5 commit 821954f
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions llvm/include/llvm/DebugInfo/DWARF/DWARFDebugInfoEntry.h
Expand Up @@ -24,6 +24,11 @@ class DWARFDebugInfoEntry {
/// Offset within the .debug_info of the start of this entry.
uint64_t Offset = 0;

// FIXME: This could be changed to a parent_idx/sibling_idx based solution
// like lldb's that could be used to improve the performance of sibling
// iteration. Memory usage is probably acceptable - if it's good enough for
// lldb it's probably good enough for llvm-symbolizer, etc.
// There's some discussion of this direction in D102634.
/// The integer depth of this DIE within the compile unit DIEs where the
/// compile/type unit DIE has a depth of zero.
uint32_t Depth = 0;
Expand Down

0 comments on commit 821954f

Please sign in to comment.