Skip to content

Commit

Permalink
[libc++][ranges][NFC] Test the specializations of `tuple_{size,elemen…
Browse files Browse the repository at this point in the history
…t}` for ranges.

Also update the synopsis in `<ranges>` to mention the specializations.

Differential Revision: https://reviews.llvm.org/D118686
  • Loading branch information
var-const committed Feb 3, 2022
1 parent 167b623 commit 823fa09
Show file tree
Hide file tree
Showing 3 changed files with 95 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libcxx/docs/Status/RangesPaper.csv
@@ -1,5 +1,5 @@
Section,Description,Dependencies,Assignee,Complete
`[tuple.helper] <https://wg21.link/tuple.helper>`_,Update <tuple> includes.,None,Konstantin Varlamov,Not started
`[tuple.helper] <https://wg21.link/tuple.helper>`_,`Update <tuple> includes. <https://llvm.org/D118686>`_,None,Konstantin Varlamov,
`[range.cmp] <https://wg21.link/range.cmp>`_,"| `ranges::equal_to <https://llvm.org/D100429>`_
| `ranges::not_equal_to <https://llvm.org/D100429>`_
| `ranges::less <https://llvm.org/D100429>`_
Expand Down
30 changes: 30 additions & 0 deletions libcxx/include/ranges
Expand Up @@ -198,6 +198,36 @@ namespace std::ranges {
class join_view;
}
namespace std {
namespace views = ranges::views;
template<class T> struct tuple_size;
template<size_t I, class T> struct tuple_element;
template<class I, class S, ranges::subrange_kind K>
struct tuple_size<ranges::subrange<I, S, K>>
: integral_constant<size_t, 2> {};
template<class I, class S, ranges::subrange_kind K>
struct tuple_element<0, ranges::subrange<I, S, K>> {
using type = I;
};
template<class I, class S, ranges::subrange_kind K>
struct tuple_element<1, ranges::subrange<I, S, K>> {
using type = S;
};
template<class I, class S, ranges::subrange_kind K>
struct tuple_element<0, const ranges::subrange<I, S, K>> {
using type = I;
};
template<class I, class S, ranges::subrange_kind K>
struct tuple_element<1, const ranges::subrange<I, S, K>> {
using type = S;
};
}
*/

// Make sure all feature-test macros are available.
Expand Down
@@ -0,0 +1,64 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// UNSUPPORTED: libcpp-has-no-incomplete-ranges

// <ranges>

// template<class T> struct tuple_size;
// template<size_t I, class T> struct tuple_element;

#include <ranges>
// Note: make sure to not include `<utility>` (or any other header including `<utility>`) because it also makes some
// tuple specializations available, thus obscuring whether the `<ranges>` includes work correctly.

using Iterator = int*;

class SizedSentinel {
public:
constexpr bool operator==(int*) const;
friend constexpr ptrdiff_t operator-(const SizedSentinel&, int*);
friend constexpr ptrdiff_t operator-(int*, const SizedSentinel&);
};

static_assert(std::sized_sentinel_for<SizedSentinel, Iterator>);
using SizedRange = std::ranges::subrange<Iterator, SizedSentinel>;

using UnsizedSentinel = std::unreachable_sentinel_t;
static_assert(!std::sized_sentinel_for<UnsizedSentinel, Iterator>);
using UnsizedRange = std::ranges::subrange<Iterator, UnsizedSentinel>;

// Because the sentinel is unsized while the subrange is sized, an additional integer member will be used to store the
// size -- make sure it doesn't affect the value of `tuple_size`.
using ThreeElementRange = std::ranges::subrange<Iterator, UnsizedSentinel, std::ranges::subrange_kind::sized>;
static_assert(std::ranges::sized_range<ThreeElementRange>);

static_assert(std::tuple_size<SizedRange>::value == 2);
static_assert(std::tuple_size<UnsizedRange>::value == 2);
static_assert(std::tuple_size<ThreeElementRange>::value == 2);

template <int I, class Range, class Expected>
constexpr bool test_tuple_element() {
static_assert(std::same_as<typename std::tuple_element<I, Range>::type, Expected>);
static_assert(std::same_as<typename std::tuple_element<I, const Range>::type, Expected>);
// Note: the Standard does not mandate a specialization of `tuple_element` for volatile, so trying a `volatile Range`
// would fail to compile.

return true;
}

int main(int, char**) {
static_assert(test_tuple_element<0, SizedRange, Iterator>());
static_assert(test_tuple_element<1, SizedRange, SizedSentinel>());
static_assert(test_tuple_element<0, UnsizedRange, Iterator>());
static_assert(test_tuple_element<1, UnsizedRange, UnsizedSentinel>());

return 0;
}

0 comments on commit 823fa09

Please sign in to comment.