Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[llvm-objdump] Update offload dumping to use SHT_LLVM_OFFLOADING
In order to be more in-line with ELF semantics, a previous patch added support for a new ELF section type to indicate if a section contains offloading data. This allows us to now check using this rather than checking the section name directly. This patch updates the logic to check the type now instead. I chose to make this emit a warning if the input is not an ELF-object file. I could have made the logic fall-back to the section name, but this offloading in LLVM is currently not supported on any other targets so it's probably best to emit a warning until we improve support. Depends on D129052 Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D129053
- Loading branch information
Showing
6 changed files
with
37 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# RUN: yaml2obj %s -o %t | ||
# RUN: llvm-objdump --offloading %t 2>&1 | FileCheck -DFILENAME=%t %s | ||
|
||
--- !COFF | ||
header: | ||
Machine: IMAGE_FILE_MACHINE_AMD64 | ||
Characteristics: [] | ||
sections: | ||
- Name: .rdata | ||
Characteristics: [] | ||
SectionData: 00 | ||
symbols: | ||
|
||
# CHECK: warning: '[[FILENAME]]': --offloading is currently only supported for ELF targets |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters