Skip to content

Commit

Permalink
Android is an environment and we were comparing the android triple
Browse files Browse the repository at this point in the history
against the OS rather than the environment. Also update other
uses of OS when we meant environment in the android local code.

NFC intended.

llvm-svn: 338460
  • Loading branch information
echristo committed Jul 31, 2018
1 parent 852e88a commit 83c49e8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
Expand Up @@ -95,16 +95,16 @@ PlatformSP PlatformAndroid::CreateInstance(bool force, const ArchSpec *arch) {
}

if (create) {
switch (triple.getOS()) {
switch (triple.getEnvironment()) {
case llvm::Triple::Android:
break;

#if defined(__ANDROID__)
// Only accept "unknown" for the OS if the host is android and it
// "unknown" wasn't specified (it was just returned because it was NOT
// specified)
case llvm::Triple::OSType::UnknownOS:
create = !arch->TripleOSWasSpecified();
case llvm::Triple::EnvironmentType::UnknownEnvironment:
create = !arch->TripleEnvironmentWasSpecified();
break;
#endif
default:
Expand Down

0 comments on commit 83c49e8

Please sign in to comment.