Skip to content

Commit

Permalink
Revert "[DebugInfo] Emit DW_TAG_namelist and DW_TAG_namelist_item"
Browse files Browse the repository at this point in the history
This reverts commit 0a6fad7.
It caused failures on a number of PowerPC bots.
  • Loading branch information
nemanjai committed Aug 31, 2021
1 parent 4c066bd commit 84d4ed1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 137 deletions.
10 changes: 1 addition & 9 deletions llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
Expand Up @@ -850,8 +850,7 @@ void DwarfUnit::constructTypeDIE(DIE &Buffer, const DICompositeType *CTy) {
case dwarf::DW_TAG_variant_part:
case dwarf::DW_TAG_structure_type:
case dwarf::DW_TAG_union_type:
case dwarf::DW_TAG_class_type:
case dwarf::DW_TAG_namelist: {
case dwarf::DW_TAG_class_type: {
// Emit the discriminator for a variant part.
DIDerivedType *Discriminator = nullptr;
if (Tag == dwarf::DW_TAG_variant_part) {
Expand Down Expand Up @@ -920,13 +919,6 @@ void DwarfUnit::constructTypeDIE(DIE &Buffer, const DICompositeType *CTy) {
DIE &VariantPart = createAndAddDIE(Composite->getTag(), Buffer);
constructTypeDIE(VariantPart, Composite);
}
} else if (Tag == dwarf::DW_TAG_namelist) {
auto *Var = dyn_cast<DINode>(Element);
auto *VarDIE = getDIE(Var);
if (VarDIE) {
DIE &ItemDie = createAndAddDIE(dwarf::DW_TAG_namelist_item, Buffer);
addDIEEntry(ItemDie, dwarf::DW_AT_namelist_item, *VarDIE);
}
}
}

Expand Down
3 changes: 1 addition & 2 deletions llvm/lib/IR/Verifier.cpp
Expand Up @@ -1091,8 +1091,7 @@ void Verifier::visitDICompositeType(const DICompositeType &N) {
N.getTag() == dwarf::DW_TAG_union_type ||
N.getTag() == dwarf::DW_TAG_enumeration_type ||
N.getTag() == dwarf::DW_TAG_class_type ||
N.getTag() == dwarf::DW_TAG_variant_part ||
N.getTag() == dwarf::DW_TAG_namelist,
N.getTag() == dwarf::DW_TAG_variant_part,
"invalid tag", &N);

AssertDI(isScope(N.getRawScope()), "invalid scope", &N, N.getRawScope());
Expand Down
64 changes: 0 additions & 64 deletions llvm/test/DebugInfo/X86/namelist1.ll

This file was deleted.

62 changes: 0 additions & 62 deletions llvm/test/DebugInfo/X86/namelist2.ll

This file was deleted.

0 comments on commit 84d4ed1

Please sign in to comment.