Skip to content

Commit

Permalink
clang/unittests/Basic/SarifTest.cpp: std::optional::value => operator*
Browse files Browse the repository at this point in the history
  • Loading branch information
MaskRay committed Dec 17, 2022
1 parent ea4741d commit 852db8e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions clang/unittests/Basic/SarifTest.cpp
Expand Up @@ -120,9 +120,9 @@ TEST_F(SarifDocumentWriterTest, canCreateDocumentWithOneRun) {
ASSERT_TRUE(Driver->getString("fullName").has_value());
ASSERT_TRUE(Driver->getString("language").has_value());

EXPECT_EQ(Driver->getString("name").value(), ShortName);
EXPECT_EQ(Driver->getString("fullName").value(), LongName);
EXPECT_EQ(Driver->getString("language").value(), "en-US");
EXPECT_EQ(*Driver->getString("name"), ShortName);
EXPECT_EQ(*Driver->getString("fullName"), LongName);
EXPECT_EQ(*Driver->getString("language"), "en-US");
}

TEST_F(SarifDocumentWriterTest, addingResultsWillCrashIfThereIsNoRun) {
Expand Down Expand Up @@ -229,8 +229,8 @@ TEST_F(SarifDocumentWriterTest, addingResultWithValidRuleAndRunIsOk) {
ASSERT_TRUE(Driver->getString("name").has_value());
ASSERT_TRUE(Driver->getString("fullName").has_value());

EXPECT_EQ(Driver->getString("name").value(), "sarif test");
EXPECT_EQ(Driver->getString("fullName").value(), "sarif test runner");
EXPECT_EQ(*Driver->getString("name"), "sarif test");
EXPECT_EQ(*Driver->getString("fullName"), "sarif test runner");

// The results are as expected
EXPECT_EQ(Results->size(), 1UL);
Expand Down

0 comments on commit 852db8e

Please sign in to comment.