Skip to content

Commit

Permalink
[flang][driver] Partial revert of D157837
Browse files Browse the repository at this point in the history
This is a partial revert of https://reviews.llvm.org/D157837 - it turns
out that the LLVM test suite needs to be updated first not to use any of
the unsupported Flang options:
  * https://github.com/llvm/llvm-test-suite
Sample errors:
```
flang-new: error: unknown argument: '-fbounds-check'
flang-new: error: unknown argument: '-fcheck=all'
flang-new: error: unknown argument: '-fcheck-array-temporaries'
```

Once the test suite is updated, we can restore the reverted setting.

Broken bot:
  * https://lab.llvm.org/buildbot/#/builders/197/builds/9001

Differential Revision: https://reviews.llvm.org/D158289
  • Loading branch information
banach-space committed Aug 18, 2023
1 parent d6e7c16 commit 89053e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions clang/lib/Driver/Driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6494,8 +6494,8 @@ Driver::getOptionVisibilityMask(bool UseDriverMode) const {
return llvm::opt::Visibility(options::CLOption);
if (IsDXCMode())
return llvm::opt::Visibility(options::DXCOption);
if (IsFlangMode()) {
return llvm::opt::Visibility(options::FlangOption);
if (IsFlangMode()) {
return llvm::opt::Visibility(options::ClangOption | options::FlangOption);
}
return llvm::opt::Visibility(options::ClangOption);
}
Expand Down

0 comments on commit 89053e4

Please sign in to comment.