Skip to content

Commit

Permalink
[clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files
Browse files Browse the repository at this point in the history
After D134050, it makes sense to combine the RV64 ABI tests into a
single file in order to make it more maintainable (i.e. not having to
split tests based on the combinations of ABIs they're expected to
impact). This patch deletes duplicated tests but doesn't do much further
reorganisation beyond that.

I imagine the logical ordering of tests in the file and comments could
be further improved in the future. My personal feeling is that it's
probably not worth investing the time to try to get this "perfect", and
to instead settle for this incremental step forward. But if there's
reviewer interest in attempting to further iterate, I'm happy to do so.

Differential Revision: https://reviews.llvm.org/D140400
  • Loading branch information
asb committed Mar 15, 2023
1 parent b2093ca commit 8964d7a
Show file tree
Hide file tree
Showing 14 changed files with 3,016 additions and 2,686 deletions.
1,524 changes: 1,524 additions & 0 deletions clang/test/CodeGen/RISCV/riscv32-abi.c

Large diffs are not rendered by default.

62 changes: 0 additions & 62 deletions clang/test/CodeGen/RISCV/riscv32-ilp32-abi.c

This file was deleted.

64 changes: 0 additions & 64 deletions clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-abi.c

This file was deleted.

0 comments on commit 8964d7a

Please sign in to comment.