Skip to content

Commit

Permalink
YAMLParser: llvm::Optional => std::optional
Browse files Browse the repository at this point in the history
  • Loading branch information
MaskRay committed Dec 15, 2022
1 parent 2d0ca6b commit 8b61376
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
Expand Up @@ -92,7 +92,7 @@ ClangTidyCheck::OptionsView::getLocalOrGlobal(StringRef LocalName) const {
static Optional<bool> getAsBool(StringRef Value,
const llvm::Twine &LookupName) {

if (llvm::Optional<bool> Parsed = llvm::yaml::parseBool(Value))
if (std::optional<bool> Parsed = llvm::yaml::parseBool(Value))
return *Parsed;
// To maintain backwards compatability, we support parsing numbers as
// booleans, even though its not supported in YAML.
Expand Down
Expand Up @@ -424,8 +424,7 @@ bool IdentifierNamingCheck::HungarianNotation::isOptionEnabled(
if (Iter == StrMap.end())
return false;

llvm::Optional<bool> Parsed = llvm::yaml::parseBool(Iter->getValue());
return *Parsed;
return *llvm::yaml::parseBool(Iter->getValue());
}

void IdentifierNamingCheck::HungarianNotation::loadFileConfig(
Expand Down
3 changes: 2 additions & 1 deletion llvm/include/llvm/Support/YAMLParser.h
Expand Up @@ -45,6 +45,7 @@
#include <iterator>
#include <map>
#include <memory>
#include <optional>
#include <string>
#include <system_error>

Expand Down Expand Up @@ -78,7 +79,7 @@ bool scanTokens(StringRef Input);
std::string escape(StringRef Input, bool EscapePrintable = true);

/// Parse \p S as a bool according to https://yaml.org/type/bool.html.
llvm::Optional<bool> parseBool(StringRef S);
std::optional<bool> parseBool(StringRef S);

/// This class represents a YAML stream potentially containing multiple
/// documents.
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Support/YAMLParser.cpp
Expand Up @@ -760,7 +760,7 @@ std::string yaml::escape(StringRef Input, bool EscapePrintable) {
return EscapedInput;
}

llvm::Optional<bool> yaml::parseBool(StringRef S) {
std::optional<bool> yaml::parseBool(StringRef S) {
switch (S.size()) {
case 1:
switch (S.front()) {
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Support/YAMLTraits.cpp
Expand Up @@ -886,7 +886,7 @@ void ScalarTraits<bool>::output(const bool &Val, void *, raw_ostream &Out) {
}

StringRef ScalarTraits<bool>::input(StringRef Scalar, void *, bool &Val) {
if (llvm::Optional<bool> Parsed = parseBool(Scalar)) {
if (std::optional<bool> Parsed = parseBool(Scalar)) {
Val = *Parsed;
return StringRef();
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/Support/YAMLParserTest.cpp
Expand Up @@ -343,7 +343,7 @@ TEST(YAMLParser, FlowSequenceTokensOutsideFlowSequence) {
}

static void expectCanParseBool(StringRef S, bool Expected) {
llvm::Optional<bool> Parsed = yaml::parseBool(S);
std::optional<bool> Parsed = yaml::parseBool(S);
EXPECT_TRUE(Parsed.has_value());
EXPECT_EQ(*Parsed, Expected);
}
Expand Down

0 comments on commit 8b61376

Please sign in to comment.