Skip to content

Commit

Permalink
[analyzer] RetainRelease: Extend the workaround for VTCompressionSess…
Browse files Browse the repository at this point in the history
…ionEncode{,MultiImage}Frame.

This is a new API that has the same ownership quirk as the old API.

This is a tiny one-liner patch; changes in plists are entirely about
line numbers.
  • Loading branch information
haoNoQ committed Sep 14, 2023
1 parent 22e1df7 commit 8b8841e
Show file tree
Hide file tree
Showing 4 changed files with 2,582 additions and 2,564 deletions.
5 changes: 3 additions & 2 deletions clang/lib/Analysis/RetainSummaryManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,9 @@ const RetainSummary *RetainSummaryManager::getSummaryForObjCOrCFObject(
return getPersistentSummary(RetEffect::MakeNoRet(),
ScratchArgs,
ArgEffect(DoNothing), ArgEffect(DoNothing));
} else if (FName == "VTCompressionSessionEncodeFrame") {
// The context argument passed to VTCompressionSessionEncodeFrame()
} else if (FName == "VTCompressionSessionEncodeFrame" ||
FName == "VTCompressionSessionEncodeMultiImageFrame") {
// The context argument passed to VTCompressionSessionEncodeFrame() et.al.
// is passed to the callback specified when creating the session
// (e.g. with VTCompressionSessionCreate()) which can release it.
// To account for this possibility, conservatively stop tracking
Expand Down

0 comments on commit 8b8841e

Please sign in to comment.