Skip to content

Commit

Permalink
[lldb][NFC] Delete deleted const char* overloads of SetValueFromString
Browse files Browse the repository at this point in the history 
This came up during the review of D96817 because those deleted overloads force
the caller to explicitly create a StringRef when passing a string literal.

It seems they were added as some kind of help while migrating the code base to
StringRef in D24847, but I don't think they have any use these days and make
these functions awkward to use.

This patch just removes all the deleted overloads.

Reviewed By: tatyana-krasnukha

Differential Revision: https://reviews.llvm.org/D96861
  • Loading branch information
@Teemperor
Teemperor committed Feb 17, 2021
1 parent f8ed31c commit 8bcc037
Show file tree
Hide file tree
Showing 17 changed files with 0 additions and 51 deletions.
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueArch.h
View file
Expand Up @@ -43,9 +43,6 @@ class OptionValueArch : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueArray.h
View file
Expand Up @@ -32,9 +32,6 @@ class OptionValueArray : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_values.clear();
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueBoolean.h
View file
Expand Up @@ -33,9 +33,6 @@ class OptionValueBoolean : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueChar.h
View file
Expand Up @@ -34,9 +34,6 @@ class OptionValueChar : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueEnumeration.h
View file
Expand Up @@ -43,9 +43,6 @@ class OptionValueEnumeration : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueFileColonLine.h
View file
Expand Up @@ -31,9 +31,6 @@ class OptionValueFileColonLine : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_file_spec.Clear();
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueFileSpec.h
View file
Expand Up @@ -37,9 +37,6 @@ class OptionValueFileSpec : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueFileSpecList.h
View file
Expand Up @@ -35,9 +35,6 @@ class OptionValueFileSpecList : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
std::lock_guard<std::recursive_mutex> lock(m_mutex);
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueFormat.h
View file
Expand Up @@ -34,9 +34,6 @@ class OptionValueFormat : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueFormatEntity.h
View file
Expand Up @@ -30,9 +30,6 @@ class OptionValueFormatEntity : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override;

Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueLanguage.h
View file
Expand Up @@ -37,9 +37,6 @@ class OptionValueLanguage : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValuePathMappings.h
View file
Expand Up @@ -31,9 +31,6 @@ class OptionValuePathMappings : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_path_mappings.Clear(m_notify_changes);
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueRegex.h
View file
Expand Up @@ -32,9 +32,6 @@ class OptionValueRegex : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_regex = RegularExpression(m_default_regex_str);
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueSInt64.h
View file
Expand Up @@ -46,9 +46,6 @@ class OptionValueSInt64 : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueString.h
View file
Expand Up @@ -81,9 +81,6 @@ class OptionValueString : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueUInt64.h
View file
Expand Up @@ -43,9 +43,6 @@ class OptionValueUInt64 : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_current_value = m_default_value;
Expand Down
3 changes: 0 additions & 3 deletions lldb/include/lldb/Interpreter/OptionValueUUID.h
View file
Expand Up @@ -32,9 +32,6 @@ class OptionValueUUID : public OptionValue {
Status
SetValueFromString(llvm::StringRef value,
VarSetOperationType op = eVarSetOperationAssign) override;
Status
SetValueFromString(const char *,
VarSetOperationType = eVarSetOperationAssign) = delete;

void Clear() override {
m_uuid.Clear();
Expand Down

0 comments on commit 8bcc037

Please sign in to comment.