Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
------------------------------------------------------------------------ r369760 | szelethus | 2019-08-23 16:21:13 +0200 (Fri, 23 Aug 2019) | 13 lines [analyzer] Avoid unnecessary enum range check on LValueToRValue casts Summary: EnumCastOutOfRangeChecker should not perform enum range checks on LValueToRValue casts, since this type of cast does not actually change the underlying type. Performing the unnecessary check actually triggered an assertion failure deeper in EnumCastOutOfRange for certain input (which is captured in the accompanying test code). Reviewers: #clang, Szelethus, gamesh411, NoQ Reviewed By: Szelethus, gamesh411, NoQ Subscribers: NoQ, gamesh411, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, bjope, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66014 ------------------------------------------------------------------------ llvm-svn: 371058
- Loading branch information
Showing
3 changed files
with
59 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// RUN: %clang_analyze_cc1 \ | ||
// RUN: -analyzer-checker=core,alpha.cplusplus.EnumCastOutOfRange \ | ||
// RUN: -verify %s | ||
|
||
enum En_t { | ||
En_0 = -4, | ||
En_1, | ||
En_2 = 1, | ||
En_3, | ||
En_4 = 4 | ||
}; | ||
|
||
void unscopedUnspecifiedCStyle() { | ||
enum En_t Below = (enum En_t)(-5); // expected-warning {{not in the valid range}} | ||
enum En_t NegVal1 = (enum En_t)(-4); // OK. | ||
enum En_t NegVal2 = (enum En_t)(-3); // OK. | ||
enum En_t InRange1 = (enum En_t)(-2); // expected-warning {{not in the valid range}} | ||
enum En_t InRange2 = (enum En_t)(-1); // expected-warning {{not in the valid range}} | ||
enum En_t InRange3 = (enum En_t)(0); // expected-warning {{not in the valid range}} | ||
enum En_t PosVal1 = (enum En_t)(1); // OK. | ||
enum En_t PosVal2 = (enum En_t)(2); // OK. | ||
enum En_t InRange4 = (enum En_t)(3); // expected-warning {{not in the valid range}} | ||
enum En_t PosVal3 = (enum En_t)(4); // OK. | ||
enum En_t Above = (enum En_t)(5); // expected-warning {{not in the valid range}} | ||
} | ||
|
||
enum En_t unused; | ||
void unusedExpr() { | ||
// Following line is not something that EnumCastOutOfRangeChecker should | ||
// evaluate. Checker should either ignore this line or process it without | ||
// producing any warnings. However, compilation will (and should) still | ||
// generate a warning having nothing to do with this checker. | ||
unused; // expected-warning {{expression result unused}} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters