Skip to content

Commit

Permalink
[OpenMP] remove obsolete symbol defintions
Browse files Browse the repository at this point in the history
Some globals were used for enforcing certain linking rules in the Intel
OpenMP implementation's MSVC compatibility layer and are not applicable
to the LLVM implementation (kmp_import.cpp has already been removed from
the build).

Differential Revision:https://reviews.llvm.org/D145837
  • Loading branch information
Vadim Paretsky committed Mar 13, 2023
1 parent a92eaa3 commit 8d8cca0
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 50 deletions.
3 changes: 0 additions & 3 deletions openmp/runtime/src/dllexports
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,6 @@
__kmp_omp_debug_struct_info DATA
%endif

# Symbols for MS mutual detection:
_You_must_link_with_exactly_one_OpenMP_library DATA
_You_must_link_with_Intel_OpenMP_library DATA
__kmp_wait_64
__kmp_release_64

Expand Down
7 changes: 0 additions & 7 deletions openmp/runtime/src/kmp.h
Original file line number Diff line number Diff line change
Expand Up @@ -4184,13 +4184,6 @@ KMP_EXPORT void *__kmpc_threadprivate_cached(ident_t *loc, kmp_int32 global_tid,
void *data, size_t size,
void ***cache);

// Symbols for MS mutual detection.
extern int _You_must_link_with_exactly_one_OpenMP_library;
extern int _You_must_link_with_Intel_OpenMP_library;
#if KMP_OS_WINDOWS && (KMP_VERSION_MAJOR > 4)
extern int _You_must_link_with_Microsoft_OpenMP_library;
#endif

// The routines below are not exported.
// Consider making them 'static' in corresponding source files.
void kmp_threadprivate_insert_private_data(int gtid, void *pc_addr,
Expand Down
7 changes: 0 additions & 7 deletions openmp/runtime/src/kmp_global.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -547,13 +547,6 @@ int get_suspend_count_(void) {
void set_suspend_count_(int *value) { __kmp_suspend_count = *value; }
#endif

// Symbols for MS mutual detection.
int _You_must_link_with_exactly_one_OpenMP_library = 1;
int _You_must_link_with_Intel_OpenMP_library = 1;
#if KMP_OS_WINDOWS && (KMP_VERSION_MAJOR > 4)
int _You_must_link_with_Microsoft_OpenMP_library = 1;
#endif

kmp_target_offload_kind_t __kmp_target_offload = tgt_default;

// OMP Pause Resources
Expand Down
33 changes: 0 additions & 33 deletions openmp/runtime/src/kmp_import.cpp

This file was deleted.

0 comments on commit 8d8cca0

Please sign in to comment.