Skip to content

Commit

Permalink
[X86][TableGen] Remove unnecessary use of formatted_raw_ostream. NFC (#…
Browse files Browse the repository at this point in the history
…89343)

This code used to use the PadToColumn feature of formatted_raw_ostream,
but no longer does. formatted_raw_ostream is slower than regular
raw_ostream because it has to keep track of the number of character
since the last new line character.
  • Loading branch information
topperc committed Apr 19, 2024
1 parent 016ce9e commit 8e2060b
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions llvm/utils/TableGen/X86FoldTablesEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "Common/CodeGenTarget.h"
#include "X86RecognizableInstr.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/FormattedStream.h"
#include "llvm/Support/X86FoldTablesUtils.h"
#include "llvm/TableGen/Record.h"
#include "llvm/TableGen/TableGenBackend.h"
Expand Down Expand Up @@ -95,7 +94,7 @@ class X86FoldTablesEmitter {
const CodeGenInstruction *MemInst)
: RegInst(RegInst), MemInst(MemInst) {}

void print(formatted_raw_ostream &OS) const {
void print(raw_ostream &OS) const {
OS.indent(2);
OS << "{X86::" << RegInst->TheDef->getName() << ", ";
OS << "X86::" << MemInst->TheDef->getName() << ", ";
Expand Down Expand Up @@ -222,7 +221,7 @@ class X86FoldTablesEmitter {
// Print the given table as a static const C++ array of type
// X86FoldTableEntry.
void printTable(const FoldTable &Table, StringRef TableName,
formatted_raw_ostream &OS) {
raw_ostream &OS) {
OS << "static const X86FoldTableEntry " << TableName << "[] = {\n";

for (auto &E : Table)
Expand Down Expand Up @@ -619,9 +618,7 @@ void X86FoldTablesEmitter::updateTables(const CodeGenInstruction *RegInst,
}
}

void X86FoldTablesEmitter::run(raw_ostream &O) {
formatted_raw_ostream OS(O);

void X86FoldTablesEmitter::run(raw_ostream &OS) {
// Holds all memory instructions
std::vector<const CodeGenInstruction *> MemInsts;
// Holds all register instructions - divided according to opcode.
Expand Down

0 comments on commit 8e2060b

Please sign in to comment.