Skip to content

Commit

Permalink
llvm-reduce: Fix producing invalid reductions on ifunc
Browse files Browse the repository at this point in the history
  • Loading branch information
arsenm committed Nov 27, 2022
1 parent b6909fe commit 8e3e218
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
27 changes: 27 additions & 0 deletions llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
@@ -0,0 +1,27 @@
; RUN: llvm-reduce -abort-on-invalid-reduction --delta-passes=functions --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
; RUN: FileCheck --check-prefixes=CHECK-FINAL --input-file=%t %s

; Test handling of ifunc. Make sure function reduction doesn't create
; invalid ifunc


; CHECK-INTERESTINGNESS: define void @no_ifunc_interesting

; CHECK-FINAL: @ifunc1 = ifunc void (), ptr @has_ifunc
; CHECK-FINAL: define void @no_ifunc_interesting() {
; CHECK-FINAL-NOT: define

@ifunc1 = ifunc void (), ptr @has_ifunc


define ptr @has_ifunc() {
ret ptr inttoptr (i64 124 to ptr)
}

define void @no_ifunc_interesting() {
ret void
}

define void @no_ifunc_boring() {
ret void
}
5 changes: 4 additions & 1 deletion llvm/tools/llvm-reduce/deltas/Utils.cpp
Expand Up @@ -13,6 +13,7 @@
#include "Utils.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/GlobalAlias.h"
#include "llvm/IR/GlobalIFunc.h"

using namespace llvm;

Expand All @@ -27,5 +28,7 @@ Value *llvm::getDefaultValue(Type *T) {
}

bool llvm::hasAliasUse(Function &F) {
return any_of(F.users(), [](User *U) { return isa<GlobalAlias>(U); });
return any_of(F.users(), [](User *U) {
return isa<GlobalAlias>(U) || isa<GlobalIFunc>(U);
});
}

0 comments on commit 8e3e218

Please sign in to comment.