Skip to content

Commit

Permalink
[tsan] Disable randomized address space on linux aarch64.
Browse files Browse the repository at this point in the history
Summary:
After patch https://lkml.org/lkml/2015/12/21/340 is introduced in
linux kernel, the random gap between stack and heap is increased
from 128M to 36G on 39-bit aarch64. And it is almost impossible
to cover this big range. So I think we need to disable randomized
virtual space on aarch64 linux.

Reviewers: kcc, llvm-commits, eugenis, zatrazz, dvyukov, rengolin

Subscribers: rengolin, aemerson, tberghammer, danalbert, srhines, enh

Differential Revision: http://reviews.llvm.org/D18003

llvm-svn: 264068
  • Loading branch information
yabinc committed Mar 22, 2016
1 parent 8ad55fb commit 909e600
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions compiler-rt/lib/tsan/rtl/tsan_platform_linux.cc
Expand Up @@ -36,6 +36,7 @@
#include <string.h>
#include <stdarg.h>
#include <sys/mman.h>
#include <sys/personality.h>
#include <sys/syscall.h>
#include <sys/socket.h>
#include <sys/time.h>
Expand Down Expand Up @@ -291,6 +292,20 @@ void InitializePlatform() {
SetAddressSpaceUnlimited();
reexec = true;
}
// After patch "arm64: mm: support ARCH_MMAP_RND_BITS." is introduced in
// linux kernel, the random gap between stack and mapped area is increased
// from 128M to 36G on 39-bit aarch64. As it is almost impossible to cover
// this big range, we should disable randomized virtual space on aarch64.
#if defined(__aarch64__)
int old_personality = personality(0xffffffff);
if (old_personality != -1 && (old_personality & ADDR_NO_RANDOMIZE) == 0) {
Report("WARNING: Program is run with randomized virtual address space,"
" which wouldn't work with ThreadSanitizer.\n");
Report("Re-execing with fixed virtual address space.\n");
CHECK(personality(old_personality | ADDR_NO_RANDOMIZE) != -1);
reexec = true;
}
#endif
if (reexec)
ReExec();
}
Expand Down

0 comments on commit 909e600

Please sign in to comment.