Skip to content

Commit

Permalink
[BasicAA] Remove stale FIXME (NFC)
Browse files Browse the repository at this point in the history
If aliasGEP returns MayAlias, the code does fall through to
aliasPHI etc, so this FIXME is no longer applicable.
  • Loading branch information
nikic committed Nov 21, 2020
1 parent 4629afa commit 913a99c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions llvm/lib/Analysis/BasicAliasAnalysis.cpp
Expand Up @@ -1746,8 +1746,6 @@ AliasResult BasicAAResult::aliasCheck(const Value *V1, LocationSize V1Size,
if (!Pair.second)
return Pair.first->second;

// FIXME: This isn't aggressively handling alias(GEP, PHI) for example: if the
// GEP can't simplify, we don't even look at the PHI cases.
if (const GEPOperator *GV1 = dyn_cast<GEPOperator>(V1)) {
AliasResult Result =
aliasGEP(GV1, V1Size, V1AAInfo, V2, V2Size, V2AAInfo, O1, O2, AAQI);
Expand Down

0 comments on commit 913a99c

Please sign in to comment.